GNOME Bugzilla – Bug 727188
ximagesink: Should set alpha_mask to 0 when dealing with 24bit RGB
Last modified: 2014-06-22 12:17:04 UTC
Currently we always set the alpha_mask, even if there is no alpha. This rely on the format from mask code to ignore it, it just safer to set it to zero as it should. Same has been done in ximagesrc, see https://bugzilla.gnome.org/show_bug.cgi?id=726833
Created attachment 273113 [details] [review] [PATCH] ximagesrc: only extrapolate alpha mask for 32-bit depth Instead of passing bogus alpha mask values when there's no alpha. https://bugzilla.gnome.org/show_bug.cgi?id=727188 --- sys/ximage/ximagesink.c | 9 ++++++--- 1 file changed, 6 insertions(+), 3 deletions(-)
(In reply to comment #1) > [PATCH] ximagesrc: only extrapolate alpha mask for 32-bit depth Oops, ximagesink. Fix in my repo. commit f270b267c530ccc85718b37df74a9b01f3e4bca3 Author: Nicolas Dufresne <nicolas.dufresne@collabora.com> Date: Thu Mar 27 16:43:10 2014 -0400 ximagesink: only extrapolate alpha mask for 32-bit depth Instead of passing bogus alpha mask values when there's no alpha. https://bugzilla.gnome.org/show_bug.cgi?id=727188