After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 727183 - Clean-up of 'gdm_string_hex_encode()'
Clean-up of 'gdm_string_hex_encode()'
Status: RESOLVED FIXED
Product: gdm
Classification: Core
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: GDM maintainers
GDM maintainers
Depends on:
Blocks:
 
 
Reported: 2014-03-27 19:07 UTC by christian.h.m.schramm
Modified: 2014-04-07 14:05 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Clean-up of 'gdm_string_hex_encode()' (4.92 KB, patch)
2014-03-27 19:07 UTC, christian.h.m.schramm 		none Details | Review
Removed 'gdm_string_hex_{de,en}code()' funktions (13.13 KB, patch)
2014-03-28 08:35 UTC, christian.h.m.schramm 		committed Details | Review

Description christian.h.m.schramm 2014-03-27 19:07:44 UTC 
This implementation has a number of advantages compared
to the previous one: It's shorter, it's clearer, and it
doesn't allocate memory.
Comment 1 christian.h.m.schramm 2014-03-27 19:07:46 UTC 
Created attachment 273108 [details] [review]
Clean-up of 'gdm_string_hex_encode()'
Comment 2 christian.h.m.schramm 2014-03-27 19:09:13 UTC 
I'm not sure where this function is even used: a 'grep -rI gdm_string_hex_decode' in the source directory of jhbuild only turns up the testing code for this. Hmm ...
Comment 3 Ray Strode [halfline] 2014-03-27 19:16:53 UTC 
mind submitting a patch that just drops the function from the code (and drops the associated tests)?
Comment 4 christian.h.m.schramm 2014-03-28 08:35:21 UTC 
Created attachment 273144 [details] [review]
Removed 'gdm_string_hex_{de,en}code()' funktions

These functions were appearently unused, so there's
no reason to keep them around. The corresponding
test code was removed as well.
Comment 5 christian.h.m.schramm 2014-04-05 15:34:11 UTC 
ping?
Comment 6 Ray Strode [halfline] 2014-04-07 14:05:55 UTC 
Hey thanks for this.  Sorry for the delay!