After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 727162 - accidentally links to private telepathy-logger symbols
accidentally links to private telepathy-logger symbols
Status: RESOLVED OBSOLETE
Product: empathy
Classification: Core
Component: General
3.8.x
Other Linux
: Normal normal
: ---
Assigned To: empathy-maint
empathy-maint
Depends on:
Blocks:
 
 
Reported: 2014-03-27 13:34 UTC by Simon McVittie
Modified: 2018-05-22 16:27 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Avoid accidentally linking to telepathy-logger's private API (1.50 KB, patch)
2014-04-03 19:08 UTC, Simon McVittie 		none Details | Review

Description Simon McVittie 2014-03-27 13:34:27 UTC 
Empathy includes a copy of TplActionChain from telepathy-logger. However, it also links against the telepathy-logger library, which exports _tpl_action_chain_* as private ABI to be consumed by tests, daemons, tools within telepathy-logger. This seems like a recipe for disaster.

It should rename the symbols, perhaps by throwing some #define at the problem.

We might also be able to work around this within telepathy-logger by making TplActionChain G_GNUC_INTERNAL, since nothing outside the shared library actually uses it.
Comment 1 Simon McVittie 2014-04-03 19:08:34 UTC 
Created attachment 273546 [details] [review]
Avoid accidentally linking to telepathy-logger's private API

---

I think this should work; testing it now.
Comment 2 Simon McVittie 2014-04-03 19:28:24 UTC 
(In reply to comment #1)
> testing it now

Yes, that works. Only tested on 'next' but it's probably fine for master too.
Comment 3 Simon McVittie 2014-04-08 19:31:34 UTC 
(In reply to comment #1)
> Avoid accidentally linking to telepathy-logger's private API

I pushed this to 'next' along with some Telepathy 1.0 fixes (Bug #727043), but not to 'master' yet. Please revert if there is something badly wrong with it.
Comment 4 GNOME Infrastructure Team 2018-05-22 16:27:16 UTC 
-- GitLab Migration Automatic Message --

This bug has been migrated to GNOME's GitLab instance and has been closed from further activity.

You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.gnome.org/GNOME/empathy/issues/772.