After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 727151 - Switches in header bars displayed incorrectly
Switches in header bars displayed incorrectly
Status: RESOLVED FIXED
Product: gnome-themes-standard
Classification: Core
Component: Adwaita GTK3 theme
3.12.x
Other Linux
: Normal normal
: ---
Assigned To: gnome-themes-standard-maint
gnome-themes-standard-maint
Depends on:
Blocks:
 
 
Reported: 2014-03-27 12:09 UTC by Allan Day
Modified: 2014-04-28 15:22 UTC
See Also:
GNOME target: ---
GNOME version: 3.11/3.12


Attachments
screenshot (6.04 KB, image/png)
2014-03-27 12:09 UTC, Allan Day
  Details
screenshot comparison (6.61 KB, image/png)
2014-03-27 13:37 UTC, Allan Day
  Details
Turn off text shadow for switches (752 bytes, patch)
2014-04-27 19:34 UTC, Matthias Clasen
none Details | Review

Description Allan Day 2014-03-27 12:09:41 UTC
Created attachment 273076 [details]
screenshot

See the attached screenshot - the "ON" text is repeated twice, both times in white. It doesn't look great.
Comment 1 Bastien Nocera 2014-03-27 12:16:50 UTC
Displayed twice? I don't see the problem in the screenshot. What's the way to reproduce the problem?
Comment 2 Allan Day 2014-03-27 13:37:14 UTC
Created attachment 273088 [details]
screenshot comparison

Here's a comparison: the image on the left shows a switch from the header bar (I think it's bluetooth). On the right is a screenshot of a switch from inside the power panel.

To me it looks like the text in the header bar switch has a white shadow beneath it. The result is text that is distorted and too chunky.
Comment 3 Bastien Nocera 2014-03-27 15:05:51 UTC
Slightly stretched vertically. Does this only happen with the Bluetooth panel?
Comment 4 Allan Day 2014-03-27 16:01:13 UTC
(In reply to comment #3)
> Slightly stretched vertically. Does this only happen with the Bluetooth panel?

I've certainly seen it in Search and Sharing too. I think it's any switch in the header bar.
Comment 5 Bastien Nocera 2014-04-25 00:13:43 UTC
It's caused by this line in gtk-widgets.css in Adwaita:
/*******
 * CSD *
 *******/
.titlebar {
    text-shadow: 0 1px @wm_title_shadow;
...
Comment 6 Matthias Clasen 2014-04-27 19:34:40 UTC
Created attachment 275276 [details] [review]
Turn off text shadow for switches

It has the potential to make the label look fuzzy.
Comment 7 Jakub Steiner 2014-04-28 15:22:27 UTC
landed in master as dafeea1027fce1e4912afbf598d8119f3701e9d4