After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 727144 - Properties dialogs use the wrong header bar style
Properties dialogs use the wrong header bar style
Status: RESOLVED FIXED
Product: gnome-bluetooth
Classification: Core
Component: properties
3.12.x
Other Linux
: Normal normal
: ---
Assigned To: gnome-bluetooth-general-maint@gnome.bugs
gnome-bluetooth-general-maint@gnome.bugs
Depends on:
Blocks:
 
 
Reported: 2014-03-27 11:33 UTC by Allan Day
Modified: 2014-03-27 12:51 UTC
See Also:
GNOME target: ---
GNOME version: 3.11/3.12


Description Allan Day 2014-03-27 11:33:49 UTC 
Properties dialogs for bluetooth devices have a blue "Done" button in one corner. Since they are presentation dialogs [1], they should have a close button instead.

[1] https://wiki.gnome.org/Design/HIG/Dialogs#Presentation_Dialogs
Comment 1 Bastien Nocera 2014-03-27 12:51:19 UTC 
commit 904bdbd4341ac12c7977ce6cd0afb5b014aa526e
Author: Bastien Nocera <hadess@hadess.net>
Date:   Thu Mar 27 13:47:19 2014 +0100

    settings: Fix properties dialog bugs
    
    Due to changes in GTK+, the title wasn't shown. Revert to using
    the GTK_DIALOG_USE_HEADER_BAR flag to create the dialog, using
    the dialog's title instead of our own widget, and letting
    GTK+ create a close button for us instead of using the "Done" button.
    
    https://bugzilla.gnome.org/show_bug.cgi?id=727144
    
    See also: https://bugzilla.gnome.org/show_bug.cgi?id=727145