After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 727139 - Passwords are not stored
Passwords are not stored
Status: RESOLVED FIXED
Product: epiphany
Classification: Core
Component: Passwords, Cookies, & Certificates
3.12.x (obsolete)
Other Linux
: Normal major
: ---
Assigned To: Epiphany Maintainers
Epiphany Maintainers
: 727956 733860 734994 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2014-03-27 07:51 UTC by Mattias Eriksson
Modified: 2014-08-19 15:47 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Wait for name acquisition before we register and emit notifications (1.69 KB, patch)
2014-07-09 18:09 UTC, Gustavo Noronha (kov)
committed Details | Review
Add sanity check warning for finding extensions (924 bytes, patch)
2014-07-09 18:09 UTC, Gustavo Noronha (kov)
committed Details | Review

Description Mattias Eriksson 2014-03-27 07:51:28 UTC
Using epiphany from the fedora copr http://copr.fedoraproject.org/coprs/rhughes/f20-gnome-3-12/ I notice that it will not store any passwords. I have logged in to accounts.google.com, this bugzilla and a few other places, and I have not seen any offer to store the password. The manage password dialog is also empty.
Comment 1 Yosef Or Boczko 2014-03-27 17:54:42 UTC
What is the output of this command?
$ gsettings get org.gnome.Epiphany remember-passwords
Comment 2 Mattias Eriksson 2014-03-27 21:19:45 UTC
I made sure that the "Remember password" option was checked. And the output of that command also shows that it is set in gsettngs.
$ gsettings get org.gnome.Epiphany remember-passwords
true
Comment 3 Torben Andresen 2014-06-03 08:17:12 UTC
Epiphany on ArchLinux has the same Problem: https://bugs.archlinux.org/task/40542
Comment 4 Gustavo Noronha (kov) 2014-07-09 17:51:48 UTC
*** Bug 727956 has been marked as a duplicate of this bug. ***
Comment 5 Gustavo Noronha (kov) 2014-07-09 18:02:02 UTC
This is a regression from the multiple web processes I think. The problem is the page created notification is emitted before the service has a name, the handler on the UI process side fails to find the extension in its list and it never gets the EphyWebView::page_created_cb called, leading to the view never connecting to the form-auth-data-save-requested signal.

Patch incoming.
Comment 6 Gustavo Noronha (kov) 2014-07-09 18:09:07 UTC
Created attachment 280293 [details] [review]
Wait for name acquisition before we register and emit notifications

The UI side relies on having the name of the owner to find the extension on
its linked list. If we start emiting signals before that has been acquired,
we will miss page created signals.
Comment 7 Gustavo Noronha (kov) 2014-07-09 18:09:11 UTC
Created attachment 280294 [details] [review]
Add sanity check warning for finding extensions

That will help debugging future issues with extensions not being found.
Comment 8 Carlos Garcia Campos 2014-07-10 07:29:22 UTC
Review of attachment 280293 [details] [review]:

Good catch, thank you!
Comment 9 Carlos Garcia Campos 2014-07-10 07:29:50 UTC
Review of attachment 280294 [details] [review]:

Makes sense
Comment 10 Carlos Garcia Campos 2014-07-10 07:30:02 UTC
Review of attachment 280294 [details] [review]:

Makes sense
Comment 11 Gustavo Noronha (kov) 2014-07-10 12:55:13 UTC
Attachment 280293 [details] pushed as c66c1d1 - Wait for name acquisition before we register and emit notifications
Attachment 280294 [details] pushed as 6892dd5 - Add sanity check warning for finding extensions
Comment 12 Torben Andresen 2014-07-13 20:08:17 UTC
Will this fix be available for the current version or de we have to wait for Gnome 3.14?
Comment 13 Gustavo Noronha (kov) 2014-07-16 18:08:22 UTC
I also pushed it to the gnome-3-12 branch, so it should be in 3.12.2 when it gets released.
Comment 14 Michael Catanzaro 2014-08-01 15:53:45 UTC
*** Bug 733860 has been marked as a duplicate of this bug. ***
Comment 15 Michael Catanzaro 2014-08-19 15:47:56 UTC
*** Bug 734994 has been marked as a duplicate of this bug. ***