After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 727084 - Integrate the help with Photos 3.12
Integrate the help with Photos 3.12
Status: RESOLVED FIXED
Product: gnome-photos
Classification: Applications
Component: general
3.12.x
Other Linux
: Normal normal
: ---
Assigned To: GNOME photos maintainer(s)
GNOME photos maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2014-03-26 10:47 UTC by Aruna Sankaranarayanan
Modified: 2014-04-02 22:54 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Patch for help button in Photos (3.73 KB, patch)
2014-03-26 10:51 UTC, Aruna Sankaranarayanan
committed Details | Review
Translations for the "help" string in all languages (19.63 KB, patch)
2014-03-26 10:51 UTC, Aruna Sankaranarayanan
none Details | Review
translations of the "_Help" string (19.56 KB, patch)
2014-04-02 18:53 UTC, Kat
committed Details | Review

Description Aruna Sankaranarayanan 2014-03-26 10:47:32 UTC
The user help(Currently a work-in-progress here: https://bugzilla.gnome.org/show_bug.cgi?id=711505) needs to be integrated with Photos for 3.12. The following patches contain code for the help button to go into Photos and translations for the "help" string in all the languages currently in Photos.
Comment 1 Aruna Sankaranarayanan 2014-03-26 10:51:06 UTC
Created attachment 272981 [details] [review]
Patch for help button in Photos
Comment 2 Aruna Sankaranarayanan 2014-03-26 10:51:40 UTC
Created attachment 272982 [details] [review]
Translations for the "help" string in all languages
Comment 3 Debarshi Ray 2014-03-26 11:17:42 UTC
Is this not a duplicate of bug 711505 ? I can see a patch that adds the "help" button and a patch that adds the translations. Or am I missing something.

Thanks for working on the user help, though.
Comment 4 Aruna Sankaranarayanan 2014-03-26 11:19:02 UTC
No, these are only for the build. e wanted to keep these patches separate from userdocs. 

Also, fresh drafts coming up for the help in the other bug! ;)
Comment 5 Debarshi Ray 2014-03-26 11:22:59 UTC
(In reply to comment #4)
> No, these are only for the build. e wanted to keep these patches separate from
> userdocs. 

So should those patches be removed from bug 711505 ? As far as I can make out, these 2 are the same.
Comment 6 Kat 2014-04-02 18:53:55 UTC
Created attachment 273491 [details] [review]
translations of the "_Help" string
Comment 7 Kat 2014-04-02 18:54:37 UTC
(In reply to comment #5)
> (In reply to comment #4)
> > No, these are only for the build. e wanted to keep these patches separate from
> > userdocs. 
> 
> So should those patches be removed from bug 711505 ? As far as I can make out,
> these 2 are the same.

Indeed, which seems like someone has already done.
Comment 8 Kat 2014-04-02 22:51:01 UTC
Comment on attachment 272981 [details] [review]
Patch for help button in Photos

Pushed to master in commit 5859b3364748c7338ec743f2ab4065364967e180

Pushed to gnome-3-12 with approval from the translators in commit 5859b3364748c7338ec743f2ab4065364967e180
Comment 9 Kat 2014-04-02 22:52:26 UTC
Comment on attachment 273491 [details] [review]
translations of the "_Help" string

Pushed to master in commit f66137ba95613187c1ba2b86f5ddcf5be6baec87

Pushed to gnome-3-12 with approval from the translators in commit 5859b3364748c7338ec743f2ab4065364967e180
Comment 10 Kat 2014-04-02 22:53:50 UTC
(In reply to comment #8)
> (From update of attachment 272981 [details] [review])
> Pushed to master in commit 5859b3364748c7338ec743f2ab4065364967e180
> 
> Pushed to gnome-3-12 with approval from the translators in commit
> 5859b3364748c7338ec743f2ab4065364967e180

That should be 9c31d671e480d9c180d606603a81cc51a678a610 for gnome-3-12
Comment 11 Kat 2014-04-02 22:54:32 UTC
(In reply to comment #9)
> (From update of attachment 273491 [details] [review])
> Pushed to master in commit f66137ba95613187c1ba2b86f5ddcf5be6baec87
> 
> Pushed to gnome-3-12 with approval from the translators in commit
> 5859b3364748c7338ec743f2ab4065364967e180

and 8cc2e79cb93388153985c5047fb0673ccb4621f4 here