After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 727080 - W32: Window re-size grip looks UGLY.
W32: Window re-size grip looks UGLY.
Status: RESOLVED FIXED
Product: gtk+
Classification: Platform
Component: Themes
unspecified
Other All
: Normal normal
: ---
Assigned To: gtk-bugs
gtk-bugs
Depends on:
Blocks:
 
 
Reported: 2014-03-26 07:25 UTC by LRN
Modified: 2014-04-04 10:18 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
W32: re-enable grip theming (999 bytes, patch)
2014-03-26 07:25 UTC, LRN
committed Details | Review
How it looks without the patch (16.01 KB, image/png)
2014-03-26 07:26 UTC, LRN
  Details
How it looks with the patch (15.94 KB, image/png)
2014-03-26 07:26 UTC, LRN
  Details

Description LRN 2014-03-26 07:25:37 UTC
I have no idea why. It seems that the grip is drawn by taking bg_color,
then filling the rectangle with it, and drawing with the lighter version
on top of that. For some reason region clipping does not work, and it does
turn out to be a rectangle instead of a triangle. That said, triangle wouldn't
have looked much better, IMO.

Anyway, turns out, there's a style code for grip that was disabled.
Re-enabling it fixes everything for me.

Paned widget (which also has a grip) is not affected, since its grip is never drawn.
Comment 1 LRN 2014-03-26 07:25:41 UTC
Created attachment 272974 [details] [review]
W32: re-enable grip theming
Comment 2 LRN 2014-03-26 07:26:01 UTC
Created attachment 272975 [details]
How it looks without the patch
Comment 3 LRN 2014-03-26 07:26:22 UTC
Created attachment 272976 [details]
How it looks with the patch
Comment 4 Matthias Clasen 2014-03-26 14:19:19 UTC
looks much better indeed
Comment 5 Matthias Clasen 2014-03-26 14:19:50 UTC
Review of attachment 272974 [details] [review]:

ok
Comment 6 LRN 2014-04-04 10:18:47 UTC
Attachment 272974 [details] pushed as b678af0 - W32: re-enable grip theming