After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 727078 - W32: GtkPopover is transparent and non-interactable
W32: GtkPopover is transparent and non-interactable
Status: RESOLVED FIXED
Product: gtk+
Classification: Platform
Component: Themes
unspecified
Other All
: Normal normal
: ---
Assigned To: gtk-bugs
gtk-bugs
Depends on:
Blocks:
 
 
Reported: 2014-03-26 07:05 UTC by LRN
Modified: 2014-04-04 10:17 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
W32: Add GtkPopover theming (1.44 KB, patch)
2014-03-26 07:05 UTC, LRN
committed Details | Review
How it looks without the patch (3.33 KB, image/png)
2014-03-26 07:05 UTC, LRN
  Details
How it looks with the patch (2.80 KB, image/png)
2014-03-26 07:06 UTC, LRN
  Details

Description LRN 2014-03-26 07:05:21 UTC
This seems to be because there's no style for it.
Comment 1 LRN 2014-03-26 07:05:25 UTC
Created attachment 272971 [details] [review]
W32: Add GtkPopover theming
Comment 2 LRN 2014-03-26 07:05:52 UTC
Created attachment 272972 [details]
How it looks without the patch
Comment 3 LRN 2014-03-26 07:06:09 UTC
Created attachment 272973 [details]
How it looks with the patch
Comment 4 Carlos Garnacho 2014-03-26 12:17:14 UTC
Review of attachment 272971 [details] [review]:

::: gtk/resources/theme/gtk-win32-base.css
@@ +1344,3 @@
+/* Mostly an expanded copy from Adwaita at this point.
+   This is definitely better than NOT having any theme at all
+   (that results in transparent, non-interactable popovers). */

Commit logs are the place for grumpy comments, not source files ;).

Other than this, I think it looks good. I guess there's no similar stock widget in Windows we have to mimic the style for.
Comment 5 Matthias Clasen 2014-03-26 14:03:23 UTC
Review of attachment 272971 [details] [review]:

thanks for the patch !
Comment 6 LRN 2014-04-04 10:17:14 UTC
Attachment 272971 [details] pushed (with grumpy comments removed) as e0a80d1 - W32: Add GtkPopover theming