After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 727072 - ConsoleKit: a pair of tweaks
ConsoleKit: a pair of tweaks
Status: RESOLVED FIXED
Product: gdm
Classification: Core
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: GDM maintainers
GDM maintainers
Depends on:
Blocks:
 
 
Reported: 2014-03-26 04:36 UTC by Allison Karlitskaya (desrt)
Modified: 2014-03-26 13:48 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
ConsoleKit: a pair of tweaks (2.69 KB, patch)
2014-03-26 04:36 UTC, Allison Karlitskaya (desrt)
committed Details | Review

Description Allison Karlitskaya (desrt) 2014-03-26 04:36:36 UTC
It looks like there were a couple of breaks when porting away from
ck-connector.

The first issue is that consolekit uses some hard-coded rules to decide
if a given session is associated with the hard-coded 'Seat1' or not.
One of these rules is the "x11-display-device" property being set.  We
were setting the "display-device" property instead, which is not for
graphical sessions.  This was causing a new seat to be dynamically
created each time gdm started which was causing us to send
ActivateSession requests to the wrong seat.

The second issue is that ActivateSession will "fail" with "Session
already active" errors.  Ignore those.
Comment 1 Allison Karlitskaya (desrt) 2014-03-26 04:36:37 UTC
Created attachment 272955 [details] [review]
ConsoleKit: a pair of tweaks
Comment 2 Ray Strode [halfline] 2014-03-26 13:47:58 UTC
sure, though I'd like to drop the consolekit code entirely for 3.14 if possible.
Comment 3 Ray Strode [halfline] 2014-03-26 13:48:43 UTC
Attachment 272955 [details] pushed as 1d76114 - ConsoleKit: a pair of tweaks