GNOME Bugzilla – Bug 727069
Show a close button instead of done button in the preferences dialog
Last modified: 2014-04-14 03:16:46 UTC
In the current preferences there is only done button at the end, but there isn't title to the dialog. I removed the done button, and instead I added the close button from the headerbar.
Created attachment 272951 [details] [review] preferences.js: Show a close button instead of the done button in the headerbar
tldr: I think it might be better to keep the done button and add a cancel button. This requires adding some code to check the format currently set for the recording when the dialog is launched, save it, and then revert to it if the cancel button is pressed. If you are interested in writing a patch for that I'm happy to accept one :) During design review it was suggested that the different formatting options and the volume controls be removed from the dialog. I'm going to be removing the volume controls this cycle. I think I will keep the formatting options but change the default to FLAC and also add automatic transcoding when a file is shared.
However, Allan just commented on a different bug and pointed out these guidelines: https://wiki.gnome.org/Design/HIG/Dialogs#Instant_.26_Explicit_Apply which state that explicit apply should not be used unless necessary, so I'll look at your patch soon and most likely accept it.
Review of attachment 272951 [details] [review]: Committed in https://git.gnome.org/browse/gnome-sound-recorder/commit/?id=824715b6130c1dcafc17d35bc68f635ad98365e5
Committed, closing the bug. Thanks again!