After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 727053 - Use header bar in the dialogs
Use header bar in the dialogs
Status: RESOLVED FIXED
Product: four-in-a-row
Classification: Applications
Component: general
3.11.x
Other Linux
: Normal normal
: ---
Assigned To: four-in-a-row-maint
four-in-a-row-maint
Depends on:
Blocks:
 
 
Reported: 2014-03-25 22:15 UTC by Yosef Or Boczko
Modified: 2014-08-18 22:05 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Use headerbar in the scores dialog (927 bytes, patch)
2014-03-25 22:15 UTC, Yosef Or Boczko 		needs-work Details | Review
Use headerbar in the preferences dialog (932 bytes, patch)
2014-03-25 22:16 UTC, Yosef Or Boczko 		accepted-commit_now Details | Review
Require GTK+ 3.12 (756 bytes, patch)
2014-04-06 22:50 UTC, Michael Catanzaro 		none Details | Review
Center text in the scores dialog (890 bytes, patch)
2014-08-18 22:05 UTC, Michael Catanzaro 		committed Details | Review
Use headerbar in the scores dialog (933 bytes, patch)
2014-08-18 22:05 UTC, Michael Catanzaro 		committed Details | Review

Description Yosef Or Boczko 2014-03-25 22:15:00 UTC 
See the patches.
Comment 1 Yosef Or Boczko 2014-03-25 22:15:53 UTC 
Created attachment 272911 [details] [review]
Use headerbar in the scores dialog
Comment 2 Yosef Or Boczko 2014-03-25 22:16:04 UTC 
Created attachment 272912 [details] [review]
Use headerbar in the preferences dialog
Comment 3 Michael Catanzaro 2014-03-26 13:40:31 UTC 
Review of attachment 272912 [details] [review]:

Looks great
Comment 4 Michael Catanzaro 2014-03-26 13:42:06 UTC 
Review of attachment 272911 [details] [review]:

I do want a header bar here, but this looks really bad. Well, it already looked bad, and I think it's going to continue to look bad no matter what without a redesign, but the header bar makes it way worse.

Can you try to center the scores in the window?
Comment 5 Yosef Or Boczko 2014-03-26 19:05:38 UTC 
Hmm, not sure how to do this.
I tried with gtk_box_set_center_widget() but
this donsn't work for me.
Comment 6 Michael Catanzaro 2014-04-06 22:50:26 UTC 
Created attachment 273676 [details] [review]
Require GTK+ 3.12

For GTK_DIALOG_USE_HEADER_BAR
Comment 7 Michael Catanzaro 2014-08-18 22:05:29 UTC 
The following fixes have been pushed:
a7b44c2 Center text in the scores dialog
985918e Use headerbar in the scores dialog
Comment 8 Michael Catanzaro 2014-08-18 22:05:32 UTC 
Created attachment 283833 [details] [review]
Center text in the scores dialog

This looks bad, BUT NOT AS BAD AS BEFORE!
Comment 9 Michael Catanzaro 2014-08-18 22:05:34 UTC 
Created attachment 283834 [details] [review]
Use headerbar in the scores dialog