Created attachment 272907 [details] [review]
Use headerbar in the scores dialog

Created attachment 272908 [details] [review]
Use headerbar in the preferences dialog

Review of attachment 272908 [details] [review]:

Good

Created attachment 272992 [details]
Screenshot of new scores dialog

Review of attachment 272907 [details] [review]:

The dialog is too wide; we'll need to rethink the buttons that we provide, currently "Close" (intended to quit the game) and "New Game."

Hey Mario, what do you think about the scores dialog? Maybe we could have a suggested New Game action in the upper left, and have the standard window decoration close button in the upper right? Just brainstorming.

Maybe we could take this as an opportunity to make the buttons more consistent across games. I don't currently have time to research what buttons each game provides in the scores dialog. I think all C games are the same (just close), but I think we decided that some of the Vala games would have a quit the game button, and some would have a close the dialog button instead. Maybe that wasn't a great choice.

I like the buttons in the header bar very much but if that were icons, that would be the best of both worlds.

As I said in the mailing list, having a new-game-icon in the header bar that may or may not open a small popover menu (depending if there were general options for the new game) would solve many problems.

Maybe we should think about moving the buttons in the header bar but also having them as consistent icons. "If I click that, I get a new game. Always. For all games."

But as it is now, the dialog is too wide. But I like it more in the header bar.

One problem is that our new game icon (view-refresh -- needs to be copied so that we have it under a reasonable name) is not very good; I'd actually prefer to just write out "New Game" in text, like I did in Chess.

I actually thought, for the header-bar at least (because that would be what all games would have in common), GTK_STOCK_NEW. The view-refresh is "play that one again" whereas the "New Game" actually could be more elaborate (and I think it should be in some cases).

Having that on every game in the top right with (were applicable) a popover with some options (either difficulty or opponent - the most general option available) would be good for the users.
Games could have another "play that one again" as view refresh where this would be useful. I would think for games that are either over very fast (mines) or games that end on their own (quadrapassel), there would be an "again" in the window as well.

I think there could be some proper rules. Maybe we should generate a matrix about the kind of games with "finishes even without interaction", "puzzle", "two-player" and so on. Maybe we find some common rules that could be generally applicable.

Created attachment 273016 [details] [review]
Use headerbar in the scores dialog

I just added the "suggested-action" style to the new game button.

I agree that some games should have a Play Again button that bypasses the new game screen, but you're getting too far ahead here: only Mines and Sudoku currently have a new game screen, and the only remaining portion of this bug is the scores dialog. I think we should not overload the user with ways to exit from the scores dialog.  A button that's actually a menu of options would probably be a overkill here.

Perhaps the best thing to do is just remove all the buttons from the score dialog: let the user return to the game over screen and use the normal new game (or play again, if available) button. This adds one additional click, but seems tolerable.

We're actually going to restore the ability to save player names in the scores dialog, which will resolve the width issue.

Created attachment 273677 [details] [review]
Require GTK+ 3.12, Vala 0.24

For GtkDialog use_header_bar

We're going to deal with the scores dialog separately. Pushing the preferences dialog patch now; thanks!

Attachment 272908 [details] pushed as 98a92fe - Use headerbar in the preferences dialog
Attachment 273677 [details] pushed as ca06300 - Require GTK+ 3.12, Vala 0.24