After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 727039 - Move user list into a popover
Move user list into a popover
Status: RESOLVED FIXED
Product: polari
Classification: Applications
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: Polari maintainers
Polari maintainers
Depends on:
Blocks:
 
 
Reported: 2014-03-25 18:27 UTC by Florian Müllner
Modified: 2014-03-30 01:19 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
entryArea: Replay events instead of forcing focus on entry (3.17 KB, patch)
2014-03-25 18:27 UTC, Florian Müllner
committed Details | Review
ui: Move user list into a popover (8.32 KB, patch)
2014-03-25 18:27 UTC, Florian Müllner
committed Details | Review
userList: Stop using a stack (2.41 KB, patch)
2014-03-25 18:27 UTC, Florian Müllner
committed Details | Review
userList: Adapt style to popover changes (2.60 KB, patch)
2014-03-25 18:28 UTC, Florian Müllner
committed Details | Review
Revert "app: Restore previous state when 'user-list' action is enabled" (1.47 KB, patch)
2014-03-25 18:28 UTC, Florian Müllner
committed Details | Review

Description Florian Müllner 2014-03-25 18:27:48 UTC
This used to be in the popover branch, attaching for bug reference.
Comment 1 Florian Müllner 2014-03-25 18:27:52 UTC
Created attachment 272894 [details] [review]
entryArea: Replay events instead of forcing focus on entry

Keeping key focus on the entry interferes with GtkPopover's modal
tracking, so allow moving the key focus away, but replay "normal"
key events to the entry.
Comment 2 Florian Müllner 2014-03-25 18:27:55 UTC
Created attachment 272895 [details] [review]
ui: Move user list into a popover

Currently the user list design is quite odd, as it looks very much
like a traditional sidebar, but behaves different being overlaid
over the chat log. Bring the look in line with the behavior by using
a popover instead, which is what was in the mockups all along.
Comment 3 Florian Müllner 2014-03-25 18:27:59 UTC
Created attachment 272896 [details] [review]
userList: Stop using a stack

By using a modal popover, the user list has now become a lot more
temporary. As a result, there is no longer a need for transitioning
between different lists on room switches, so we can just add the
correct list to the popover instead of keeping all lists around in
a stack. As GtkStack does a rather poor job at not propagating state
to non-visible children, this speeds up the UI significantly.
Comment 4 Florian Müllner 2014-03-25 18:28:02 UTC
Created attachment 272897 [details] [review]
userList: Adapt style to popover changes

After changing the sidebar into a popover, borders and spacing looks
slightly off; tweak them a bit to fit the new UI.
Comment 5 Florian Müllner 2014-03-25 18:28:06 UTC
Created attachment 272898 [details] [review]
Revert "app: Restore previous state when 'user-list' action is enabled"

With the move to a popover, the user list has become a lot more
transient - in particular, the popover should never stay open
across room changes, so there is no state to restore when coming
from a room without user list (e.g. private chat).

This reverts commit 21455581a05801e39923ad287630cf810e6ff91c.
Comment 6 Florian Müllner 2014-03-25 18:46:40 UTC
Attachment 272894 [details] pushed as 3739e7f - entryArea: Replay events instead of forcing focus on entry
Attachment 272895 [details] pushed as cf953db - ui: Move user list into a popover
Attachment 272896 [details] pushed as 9ab1ab5 - userList: Stop using a stack
Attachment 272897 [details] pushed as 99bb16d - userList: Adapt style to popover changes
Attachment 272898 [details] pushed as 2820353 - Revert "app: Restore previous state when 'user-list' action is enabled"
Comment 7 Eduard Gotwig 2014-03-30 00:02:59 UTC
I don't like this change.

I tought popovers were meant to be used for controls for content you are actually working on. Having a huge user list, content itself, be there makes it messy imho. And text on text doesnt look right. The overall feeling is awkward, IMHO.
Comment 8 erusan 2014-03-30 01:19:01 UTC
>Bring the look in line with the behavior

Or just change the behavior? Text shouldn't be covered by a sidebar. Ever.

Also, user lists are not *rarely* used. They shouldn't be transient. As has already been noted, popovers are so transient that they don't even stay open when you switch rooms. This change is going the wrong direction.