GNOME Bugzilla – Bug 727039
Move user list into a popover
Last modified: 2014-03-30 01:19:01 UTC
This used to be in the popover branch, attaching for bug reference.
Created attachment 272894 [details] [review] entryArea: Replay events instead of forcing focus on entry Keeping key focus on the entry interferes with GtkPopover's modal tracking, so allow moving the key focus away, but replay "normal" key events to the entry.
Created attachment 272895 [details] [review] ui: Move user list into a popover Currently the user list design is quite odd, as it looks very much like a traditional sidebar, but behaves different being overlaid over the chat log. Bring the look in line with the behavior by using a popover instead, which is what was in the mockups all along.
Created attachment 272896 [details] [review] userList: Stop using a stack By using a modal popover, the user list has now become a lot more temporary. As a result, there is no longer a need for transitioning between different lists on room switches, so we can just add the correct list to the popover instead of keeping all lists around in a stack. As GtkStack does a rather poor job at not propagating state to non-visible children, this speeds up the UI significantly.
Created attachment 272897 [details] [review] userList: Adapt style to popover changes After changing the sidebar into a popover, borders and spacing looks slightly off; tweak them a bit to fit the new UI.
Created attachment 272898 [details] [review] Revert "app: Restore previous state when 'user-list' action is enabled" With the move to a popover, the user list has become a lot more transient - in particular, the popover should never stay open across room changes, so there is no state to restore when coming from a room without user list (e.g. private chat). This reverts commit 21455581a05801e39923ad287630cf810e6ff91c.
Attachment 272894 [details] pushed as 3739e7f - entryArea: Replay events instead of forcing focus on entry Attachment 272895 [details] pushed as cf953db - ui: Move user list into a popover Attachment 272896 [details] pushed as 9ab1ab5 - userList: Stop using a stack Attachment 272897 [details] pushed as 99bb16d - userList: Adapt style to popover changes Attachment 272898 [details] pushed as 2820353 - Revert "app: Restore previous state when 'user-list' action is enabled"
I don't like this change. I tought popovers were meant to be used for controls for content you are actually working on. Having a huge user list, content itself, be there makes it messy imho. And text on text doesnt look right. The overall feeling is awkward, IMHO.
>Bring the look in line with the behavior Or just change the behavior? Text shouldn't be covered by a sidebar. Ever. Also, user lists are not *rarely* used. They shouldn't be transient. As has already been noted, popovers are so transient that they don't even stay open when you switch rooms. This change is going the wrong direction.