GNOME Bugzilla – Bug 727035
W32: Combobox button is drawn with two arrows
Last modified: 2014-04-04 10:09:24 UTC
W32 theme part already draws an arrow as part of the background, and GTK draws its own arrow on top of that.
Created attachment 272876 [details] [review] W32: Fix double-arrowed combobox button The arrow is part of the background image drawn by the theme, don't draw GTK's own arrow.
Created attachment 272878 [details] How it looks without the patch
Created attachment 272879 [details] How it looks with the patch
Review of attachment 272876 [details] [review]: I wonder if we support the "display:none" property; it would be slightly clearer than drawing with a transparent color.
Theme parsing error: gtk.css:169:7: 'display' is not a valid property name
No, this is wrong. This patch removes the arrow from all comboboxes, but we only need to remove it from the ones that have "has-entry" set. Either that, or change how comboboxes without entry are drawn (right now it seems that GTK is mostly responsible for them).
Created attachment 272961 [details] [review] W32: Fix double-arrowed combobox button (v2) The arrow is part of the background image drawn by the theme, don't draw GTK's own arrow. This also applies to non-entry comboboxes.
Created attachment 272962 [details] How it looks without the patch
Created attachment 272963 [details] How it looks with the patch
Created attachment 273132 [details] [review] W32: Fix double-arrowed combobox button (v3) The arrow is part of the background image drawn by the theme, don't draw GTK's own arrow. This also applies to non-entry comboboxes. On XP the arrow-and-nothing-else part does not exist (W32 XP theme draws a white rectangle) and has to be subtituted for a simple dropdown button even for non-entry comboboxes.
Ok for me.
Review of attachment 273132 [details] [review]: ok
Attachment 273132 [details] pushed as 2b36054 - W32: Fix double-arrowed combobox button