After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 727029 - fails to buils when vala is enabled
fails to buils when vala is enabled
Status: RESOLVED FIXED
Product: vala
Classification: Core
Component: general
unspecified
Other OpenBSD
: Normal normal
: ---
Assigned To: Vala maintainers
Vala maintainers
Depends on:
Blocks:
 
 
Reported: 2014-03-25 16:29 UTC by Antoine Jacoutot
Modified: 2014-03-30 16:48 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Update atk vala bindings (12.36 KB, patch)
2014-03-30 11:48 UTC, Luca Bruno
none Details | Review

Description Antoine Jacoutot 2014-03-25 16:29:26 UTC
Hi.

Building gucharmap 3.10.1 and 3.12.0 on OpenBSD with "--enable-vala" breaks with:

(process:13155): GLib-GObject-WARNING **: invalid class cast from 'GucharmapChartableAccessible' to 'GtkAccessible'
gucharmap-chapters-model.c:133: Warning: Gucharmap: gucharmap_chapters_model_id_to_iter: unknown parameter 'chapters_model' in documentation comment, should be 'model'
/usr/local/bin/g-ir-compiler --includedir=. --includedir=. Gucharmap-2.90.gir -o Gucharmap-2.90.typelib
/usr/local/bin/vapigen-0.24  --library gucharmap-2.90 --metadatadir . --vapidir /usr/local/share/vala/vapi  --pkg glib-2.0 --pkg pango --pkg gdk-3.0 --pkg gtk+-3.0 Gucharmap-2.90.gir
Gucharmap-2.90.gir:1424.7-1424.33: error: The type name `Atk.TableCell' could not be found
      <implements name="Atk.TableCell"/>
      ^^^^^^^^^^^^^^^^^^^^^^^^^^^
Generation failed: 1 error(s), 0 warning(s)

Installed packages that can be relevant:
vala 0.24.0
gobject-introspection 1.39.90
glib 2.40.0
atk 2.12.0
gtk 3.12.0
atk 2.12.0
Comment 1 Christian Persch 2014-03-25 17:16:51 UTC
Works here using an older atk. Nothing to do with gucharmap; trying atk.
Comment 2 Alejandro Piñeiro Iglesias (IRC: infapi00) 2014-03-27 12:18:53 UTC
(In reply to comment #1)
> Works here using an older atk. Nothing to do with gucharmap; trying atk.

Works with an older one as AtkTableCell is relatively new. It was added on 2.11.90 (so included just before the API/ABI breeze). I'm not really familiar to vala, but after a quick look I found a file vapi/atk.vapi file, that seems to be manually handled. So it seems that this new atk interface is not yet included there.

Moving to vala.
Comment 3 Luca Bruno 2014-03-30 11:48:51 UTC
Created attachment 273286 [details] [review]
Update atk vala bindings

Does this work for you?
Comment 4 Antoine Jacoutot 2014-03-30 12:01:47 UTC
(In reply to comment #3)
> Created an attachment (id=273286) [details] [review]
> Update atk vala bindings
> 
> Does this work for you?

Hi Luca. This works beautifully, thank you :-)
Comment 5 Luca Bruno 2014-03-30 16:48:49 UTC
commit ad4efc4c7b8dc13f62f14b8ecd9099baf58d2f67
Author: Luca Bruno <lucabru@src.gnome.org>
Date:   Sun Mar 30 13:47:08 2014 +0200

    atk: Update and fix metadata
    
    Fixes bug 727029

This problem has been fixed in the development version. The fix will be available in the next major software release. Thank you for your bug report.