GNOME Bugzilla – Bug 727011
wayland: Use a GPtrArray for the X server arguments array
Last modified: 2014-03-25 14:16:24 UTC
See patch.
Created attachment 272838 [details] [review] wayland: Use a GPtrArray for the X server arguments array This fixes the unitialized array members introduced previously and should avoid such mistakes again going forward.
Review of attachment 272838 [details] [review]: Can we do: char *args[] = { XWAYLAND_PATH, manager->display_name, "-wayland", "-rootless", ... }; instead?
(In reply to comment #2) > Can we do: > > char *args[] = { XWAYLAND_PATH, manager->display_name, "-wayland", > "-rootless", ... }; > > instead? If we hardcode manager->display_name to be ":0", which is basically what we are doing already, then yes.
Created attachment 272852 [details] [review] wayland: Use an array initializer for the X server arguments -- Ok, this avoids the GPtrArray.
Review of attachment 272852 [details] [review]: Thanks, this looks good.
Attachment 272852 [details] pushed as 7484d54 - wayland: Use an array initializer for the X server arguments