After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 726992 - Memory leak in cr-term.c
Memory leak in cr-term.c
Status: RESOLVED FIXED
Product: libcroco
Classification: Core
Component: General
unspecified
Other All
: Normal normal
: ---
Assigned To: libcroco maintainers
libcroco maintainers
Depends on:
Blocks:
 
 
Reported: 2014-03-24 20:22 UTC by Markus Engel
Modified: 2015-10-30 08:09 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Patch for memory leak (630 bytes, patch)
2014-03-24 20:23 UTC, Markus Engel 		none Details | Review
Patch for second memory leak (423 bytes, patch)
2014-03-24 20:48 UTC, Markus Engel 		none Details | Review

Description Markus Engel 2014-03-24 20:22:40 UTC 
The attached patch fixes a memory leak in cr_term.c. A few lines above, content is allocated by g_strndup but it is not always freed again.
Comment 1 Markus Engel 2014-03-24 20:23:52 UTC 
Created attachment 272816 [details] [review]
Patch for memory leak
Comment 2 Markus Engel 2014-03-24 20:48:25 UTC 
There's a second memory leak I forgot in the first patch.
Comment 3 Markus Engel 2014-03-24 20:48:43 UTC 
Created attachment 272819 [details] [review]
Patch for second memory leak
Comment 4 Ignacio Casal Quinteiro (nacho) 2015-10-30 08:09:02 UTC 
Pushed as https://git.gnome.org/browse/libcroco/commit/?id=d8f9915a62aa14d49170180367c07c449833ae02
Please next time attach format patches so it is easier to give you the credit.
Thanks.