After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 726989 - loginScreen: reset greeter when coming back to login screen
loginScreen: reset greeter when coming back to login screen
Status: RESOLVED FIXED
Product: gnome-shell
Classification: Core
Component: login-screen
unspecified
Other All
: Normal normal
: ---
Assigned To: Ray Strode [halfline]
gnome-shell-maint
Depends on:
Blocks:
 
 
Reported: 2014-03-24 19:58 UTC by Ray Strode [halfline]
Modified: 2014-03-25 14:42 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
loginScreen: reset greeter when coming back to login screen (9.29 KB, patch)
2014-03-24 19:58 UTC, Ray Strode [halfline]
accepted-commit_now Details | Review
loginScreen: reset greeter when coming back to login screen (9.64 KB, patch)
2014-03-24 20:33 UTC, Ray Strode [halfline]
committed Details | Review

Description Ray Strode [halfline] 2014-03-24 19:58:14 UTC
When a user logs in to a wayland session, we keep the login screen
running on the X server with the login screen running in a deactivated mode.

This commit makes sure it get reactivated when the user comes back to
the VT (from user switching, logout or just ctrl-alt-f1).

Patch needs work to fade actors back in.
Comment 1 Ray Strode [halfline] 2014-03-24 19:58:16 UTC
Created attachment 272814 [details] [review]
loginScreen: reset greeter when coming back to login screen
Comment 2 Ray Strode [halfline] 2014-03-24 19:58:55 UTC
(this is Jasper's patch, I just updated it to work with git master after performing some testing)
Comment 3 Jasper St. Pierre (not reading bugmail) 2014-03-24 20:07:27 UTC
Review of attachment 272814 [details] [review]:

I think we can live without the startup animation for now.

::: js/gdm/loginDialog.js
@@ +641,3 @@
+    _sessionActivated: function() {
+        // We fade out the shell after logging in, and then re-set
+        // the greeter wen we're VT switched to again.

"when"
Comment 4 Ray Strode [halfline] 2014-03-24 20:33:17 UTC
Created attachment 272818 [details] [review]
loginScreen: reset greeter when coming back to login screen

When a user logs in to a wayland session, we keep the login screen
running on the X server with the login screen running in a deactivated mode.

This commit makes sure it get reactivated when the user comes back to
the VT (from user switching, logout or just ctrl-alt-f1).

Patch needs work to fade actors back in.
Comment 5 Ray Strode [halfline] 2014-03-24 20:34:39 UTC
attachment 272818 [details] [review] adds the actor fade back in (though I didn't update the commit message).  It's not reliably working though.  When mutter failing to drop master on leave vt for me:

Mar 24 16:31:34 unused-10-19-63-231.boston.devel.redhat.com gnome-session[3113]: failed to drop DRM master: Bad file descriptor
Comment 6 Ray Strode [halfline] 2014-03-25 14:42:24 UTC
okay got r-t approval on #release-team, will push
Comment 7 Ray Strode [halfline] 2014-03-25 14:42:46 UTC
Attachment 272818 [details] pushed as be291ee - loginScreen: reset greeter when coming back to login screen