After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 726980 - dependency on e-d-s 3.9 is often unnecessary
dependency on e-d-s 3.9 is often unnecessary
Status: RESOLVED FIXED
Product: folks
Classification: Platform
Component: general
git master
Other Linux
: Normal enhancement
: Unset
Assigned To: folks-maint
folks-maint
Depends on:
Blocks:
 
 
Reported: 2014-03-24 16:46 UTC by Simon McVittie
Modified: 2014-03-31 23:48 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
1/2] Reduce libebook dependency when not compiling the BlueZ backend (1.39 KB, patch)
2014-03-24 16:46 UTC, Simon McVittie
accepted-commit_now Details | Review
2/2] EDS test-cases: be backwards-compatible with Evolution 3.8 (2.38 KB, patch)
2014-03-24 16:48 UTC, Simon McVittie
accepted-commit_now Details | Review

Description Simon McVittie 2014-03-24 16:46:11 UTC
I'd like to get a modern Folks and Empathy into Debian unstable without having to wait for an ABI transition from e-d-s 3.8 to 3.12.

It turns out that Folks only needs e-d-s > 3.8 if compiled with the BlueZ backend, which Debian explicitly disables at the moment anyway.

Note that "make check" does not pass for me with these patches, but it doesn't pass under jhbuild without them either (Bug #726973) so it's not a regression...
Comment 1 Simon McVittie 2014-03-24 16:46:53 UTC
Created attachment 272805 [details] [review]
1/2] Reduce libebook dependency when not compiling the BlueZ  backend

Debian unstable is currently stuck with Evolution 3.8, due to the
number of ABI transitions required to get from here to there. Folks
does not appear to need a newer version if the optional BlueZ backend
is not installed, and Debian doesn't currently enable that backend
anyway.
Comment 2 Simon McVittie 2014-03-24 16:48:35 UTC
Created attachment 272806 [details] [review]
2/2] EDS test-cases: be backwards-compatible with Evolution  3.8

The D-Bus API version changes between releases. We want all known
versions to be activatable.

---

Someone could add Evo 3.10 too, if desired, but I'm not going to test that configuration.

Not all the tests *pass*, but with a suitable pile of workarounds for warnings, "most" of them do; I think that's the best I'm going to get in the short term.
Comment 3 Travis Reitter 2014-03-27 22:17:31 UTC
Review of attachment 272805 [details] [review]:

Looks good
Comment 4 Travis Reitter 2014-03-27 22:17:40 UTC
Review of attachment 272806 [details] [review]:

Looks good
Comment 5 Travis Reitter 2014-03-27 22:29:28 UTC
Oh, and please update NEWS to note this bug is closed.
Comment 6 Travis Reitter 2014-03-31 23:48:17 UTC
Pushed to master. Thanks!


commit dda8b6beb16a9b4ab70f2448c6a90fe0d9d019af
Author: Simon McVittie <simon.mcvittie@collabora.co.uk>
Date:   Mon Mar 24 10:10:07 2014 +0000

    EDS test-cases: be backwards-compatible with Evolution 3.8
    
    The D-Bus API version changes between releases. We want all known
    versions to be activatable.
    
    https://bugzilla.gnome.org/show_bug.cgi?id=726980

 NEWS                         |  1 +
 tests/lib/eds/test-case.vala | 36 ++++++++++++++++++++++++++++++++++++
 2 files changed, 37 insertions(+)

commit da4544b9cf2a10d8d060bf8ed3e09a12006b80e8
Author: Simon McVittie <simon.mcvittie@collabora.co.uk>
Date:   Mon Mar 24 09:45:01 2014 +0000

    Reduce libebook dependency when not compiling the BlueZ backend
    
    Debian unstable is currently stuck with Evolution 3.8, due to the
    number of ABI transitions required to get from here to there. Folks
    does not appear to need a newer version if the optional BlueZ backend
    is not installed, and Debian doesn't currently enable that backend
    anyway.
    
    https://bugzilla.gnome.org/show_bug.cgi?id=726980

 configure.ac | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)