After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 726956 - Gstbaseparse: why need report error if no valid frame before EOS?
Gstbaseparse: why need report error if no valid frame before EOS?
Status: RESOLVED OBSOLETE
Product: GStreamer
Classification: Platform
Component: gstreamer (core)
1.2.3
Other Linux
: Normal normal
: git master
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2014-03-24 05:33 UTC by kevin
Modified: 2018-11-03 12:20 UTC
See Also:
GNOME target: ---
GNOME version: ---


Description kevin 2014-03-24 05:33:05 UTC 
Why need report error if no valid frame before EOS? We have one test stream which have audio track. But haven't any valid AC3 data in it. Application got error and stopped playback. Below is the source code in gstbaseparse.c


      /* If we STILL have zero frames processed, fire an error */
      if (parse->priv->framecount == 0) {
        GST_ELEMENT_ERROR (parse, STREAM, WRONG_TYPE,
            ("No valid frames found before end of stream"), (NULL));
      }
Comment 1 Tim-Philipp Müller 2014-03-24 09:09:51 UTC 
Does it have any data in it?

I have noticed a regression related to this as well though, when seeking towards the end of a file, sometimes we just get an error now about no valid frames found before end of stream.
Comment 2 Edward Hervey 2014-03-24 10:51:08 UTC 
Maybe baseparse should only fire that error on the bus if it's working in pull-mode (and driving the pipeline). If no data is seen when working in push-based, it should be up to an upstream element to handle/notify that.
Comment 3 Tim-Philipp Müller 2014-03-24 11:02:58 UTC 
push vs. pull mode is not really a suitable criterion sadly, a parser should behave roughly the same when reading from a file vs. reading from http, for example.
Comment 4 kevin 2014-03-26 01:55:45 UTC 
Do we have fix plan for it?
Comment 5 Thiago Sousa Santos 2014-06-10 19:52:33 UTC 
I think decoders handle this like this:

* If no data received and eos -> eos
* If data received but no valid output and then eos -> error
Comment 6 GStreamer system administrator 2018-11-03 12:20:00 UTC 
-- GitLab Migration Automatic Message --

This bug has been migrated to freedesktop.org's GitLab instance and has been closed from further activity.

You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.freedesktop.org/gstreamer/gstreamer/issues/52.