GNOME Bugzilla – Bug 726953
Set a limit on the max amount of time per game
Last modified: 2014-12-17 00:46:45 UTC
Created attachment 272724 [details] This might take a while. Should not allow more than three digits worth of time per player.
Created attachment 292129 [details] [review] Set a limit on the max amount of time per game Set the time limit to Hours : 10 Minutes : 999 as discussed with michael on irc.
Review of attachment 292129 [details] [review]: Hm, I can't apply this patch. Did you have other commits behind it that aren't in master yet? error: patch failed: src/gnome-chess.vala:1846 error: src/gnome-chess.vala: patch does not apply Did you hand edit your patch? It does not apply to blobs recorded in its index. ::: src/gnome-chess.vala @@ +1851,3 @@ + { + case 60: + if (duration_adjustment.get_upper() != 999) Make sure to add a space before each opening parenthesis. Your script would have caught this :p
Also, with a time limit of 10 hours, there should be a 600-minute limit, no?
Created attachment 292141 [details] [review] Set a limit on the max amount of time per game Sorry for the previous broken patch, this one should patch cleanly. Aagh, I had almost forgotten about my guideline checking script :p
(In reply to comment #3) > Also, with a time limit of 10 hours, there should be a 600-minute limit, no? The latest patch limits minutes to 600 and hours to 10.
Looks good, thanks! Attachment 292141 [details] pushed as 72054b7 - Set a limit on the max amount of time per game