GNOME Bugzilla – Bug 726951
ui: remove unnecessary size groups
Last modified: 2014-03-25 15:42:32 UTC
The horizontal size group is exacerbating the horrible resizing behavior as the clock ticks down. It's not the size group's fault that this is broken, but the size group makes it 1634435x worse. The vertical size group is simply unnecessary in 3.12. In 3.10 it is needed for the header bar buttons to have the same height, but forces the buttons into odd (non-square) shapes. Let's just remove it.
Created attachment 272723 [details] [review] ui: remove unnecessary size groups
Created attachment 272726 [details] The bottom size group can also expand the history control buttons....
Attachment 272723 [details] pushed as 53fdcac - ui: remove unnecessary size groups
Created attachment 272792 [details] Screenshot - gnome-chess in English Please, revert this patch, it not right in my screen (my resolution is 900 × 1440).
Created attachment 272795 [details] Screenshot - gnome-chess in Hebrew it more clear there is some pixels between the image-buttons to the text-button.
Aaaah, the New Game button, I missed that. Yes, agreed. The top size group was harmless anyway; I was mostly concerned about the one on the bottom. They just happened to be right next to each other. P.S. Unrelated: Looking at that screenshot, I'm going to revert [1] as well, but only in gnome-3-12. It's expected that your default fonts all contain the ratio character (pick a better fixed-width font!) and I think this will only sting Arch users, but I don't want to break that in 3.12.1 when the colon was used in 3.12.0. [1] https://git.gnome.org/browse/gnome-chess/commit/?h=gnome-3-12&id=da695c6cc43db4c52a4410aa2d8e743811cef949
The following fix has been pushed: 4812c81 Partially revert "remove unnecessary size groups"
Created attachment 272826 [details] [review] Partially revert "remove unnecessary size groups" The header bar size group was actually important: it was keeping the New Game button at the proper height. And since it wasn't causing any problems, let's just put it back.
(In reply to comment #6) > Aaaah, the New Game button, I missed that. Yes, agreed. The top size group was > harmless anyway; I was mostly concerned about the one on the bottom. They just > happened to be right next to each other. > > P.S. Unrelated: Looking at that screenshot, I'm going to revert [1] as well, > but only in gnome-3-12. It's expected that your default fonts all contain the > ratio character (pick a better fixed-width font!) and I think this will only > sting Arch users, but I don't want to break that in 3.12.1 when the colon was > used in 3.12.0. > I use Canteral, if you wonder what the font I use. > [1] > https://git.gnome.org/browse/gnome-chess/commit/?h=gnome-3-12&id=da695c6cc43db4c52a4410aa2d8e743811cef949
The time labels use the "fixed" font: $ fc-match fixed DejaVuSans.ttf: "DejaVu Sans" "Book" IIRC Arch's default "fixed" is an ancient bitmap font without Unicode coverage.
I wonder what this: $ fc-match fixed 7x13.pcf.gz: "Fixed" "Regular" I'm use Infinality-bundle fonts (freetype2-infinality, fontconfig-infinality and cairo-infinality) and the default fonts of gnome settings. this not what in default in Arch (see https://wiki.archlinux.org/index.php/Infinality-bundle%2Bfonts).
You can try: https://wiki.archlinux.org/index.php/Font_Configuration#Disable_bitmap_fonts Anyway, we've ventured quite off topic, sorry about that.