After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 726927 - Popover glitch
Popover glitch
Status: RESOLVED FIXED
Product: totem
Classification: Core
Component: general
3.11.x
Other Linux
: Normal normal
: ---
Assigned To: General Totem maintainer(s)
General Totem maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2014-03-23 16:58 UTC by Carlos Soriano
Modified: 2014-03-24 13:25 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
popoverTotem (2.75 KB, image/png)
2014-03-23 16:58 UTC, Carlos Soriano
  Details
Revert all totem_set_popover_no_shadow() bits (7.98 KB, patch)
2014-03-24 10:54 UTC, Carlos Garnacho
needs-work Details | Review
all: Revert all totem_set_popover_no_shadow() bits (8.45 KB, patch)
2014-03-24 13:09 UTC, Bastien Nocera
none Details | Review
all: Revert all totem_set_popover_no_shadow() bits (8.99 KB, patch)
2014-03-24 13:22 UTC, Bastien Nocera
committed Details | Review

Description Carlos Soriano 2014-03-23 16:58:29 UTC
Created attachment 272702 [details]
popoverTotem

Seems that the popover of the gear icon paints some area over the header bar. See attached screeenshot
Comment 1 Carlos Garnacho 2014-03-24 10:54:35 UTC
Created attachment 272753 [details] [review]
Revert all totem_set_popover_no_shadow() bits

Since GTK+ commit eb0f86d48, this hack is no longer necessary as
GtkPopover sets invariably a more fitting shape.
Comment 2 Carlos Garnacho 2014-03-24 10:56:19 UTC
It seems there was a communication problem down the line :(. Reassigning to totem.
Comment 3 Bastien Nocera 2014-03-24 11:22:10 UTC
Review of attachment 272753 [details] [review]:

Missing removal in src/Makefile.am
Comment 4 Bastien Nocera 2014-03-24 13:09:24 UTC
Created attachment 272778 [details] [review]
all: Revert all totem_set_popover_no_shadow() bits

Since GTK+ commit eb0f86d48, this hack is no longer necessary as
GtkPopover sets invariably a more fitting shape.
Comment 5 Bastien Nocera 2014-03-24 13:22:27 UTC
Created attachment 272779 [details] [review]
all: Revert all totem_set_popover_no_shadow() bits

Since GTK+ commit eb0f86d48, this hack is no longer necessary as
GtkPopover sets invariably a more fitting shape.
Comment 6 Bastien Nocera 2014-03-24 13:25:12 UTC
Attachment 272779 [details] pushed as d732c0b - all: Revert all totem_set_popover_no_shadow() bits