After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 726913 - replace libjpeg with libjpeg turbo
replace libjpeg with libjpeg turbo
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: packages
git master
Other Linux
: Normal enhancement
: 1.5.1
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2014-03-23 09:20 UTC by Nicola
Modified: 2014-09-04 08:05 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
rebased patch against today git master (3.67 KB, patch)
2014-07-07 10:44 UTC, Nicola 		none Details | Review
updated (4.61 KB, patch)
2014-07-07 11:19 UTC, Nicola 		committed Details | Review

Description Nicola 2014-03-23 09:20:47 UTC 
please take a look at this bug:

https://bugs.freedesktop.org/show_bug.cgi?id=57449

I added a tentative patch tested on windows only with cerbero buildone libjpeg-turbo, I noticed now a small typo in the recipe:

files_devel = ['include/jpeglib.h', 'include/jerror.h', 'include/jconfig.h',
     'include/jmorecfg.h','turbojpeg.h']

the last .h should be 'include/turbojpeg.h'
Comment 1 Tim-Philipp Müller 2014-03-23 09:30:46 UTC 
ooc: aren't there multiple such accelerated libjpeg variants? if yes, why this one?
Comment 2 Nicola 2014-03-23 09:41:20 UTC 
because libjpeg turbo is the accepted one, is the default in many distributions such as fedora, red hat, archlinux, ubuntu, I think only debian still use jpeg standard (https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=602034), on windows libjpeg turbo was used in gstreamer ossbuild winbuilds too (pre sdk/cerbero era)
Comment 3 Edward Hervey 2014-03-24 06:48:55 UTC 
libjpeg turbo is indeed the one replacement accepted pretty much everywhere and has acceleration for the platforms we target.
Comment 4 Nicola 2014-07-07 10:44:34 UTC 
Created attachment 280044 [details] [review]
rebased patch against today git master

what else left to do?
Comment 5 Edward Hervey 2014-07-07 11:08:29 UTC 
That patch doesn't contain the actual jpeg-turbo recipe
Comment 6 Nicola 2014-07-07 11:19:57 UTC 
Created attachment 280047 [details] [review]
updated

sorry for the mistake
Comment 7 Nicola 2014-09-03 22:36:24 UTC 
ping
Comment 8 Sebastian Dröge (slomo) 2014-09-04 08:05:29 UTC 
commit 18173bb0b0ddd21db3e10e984d10a2be3dda8d53
Author: Sebastian Dröge <sebastian@centricular.com>
Date:   Thu Sep 4 11:04:07 2014 +0300

    base-system-1.0: Include jpeg-turbo instead of libjpeg

commit 367f7a1dbe0a3e1f36557abcfa1f7dd98640e15b
Author: Nicola Murino <nicola.murino@gmail.com>
Date:   Mon Jul 7 13:16:45 2014 +0200

    recipes: replace libjpeg with libjpeg-turbo
    
    https://bugzilla.gnome.org/show_bug.cgi?id=726913