GNOME Bugzilla – Bug 726903
Scale the thumbnails on HiDpi displays
Last modified: 2014-04-15 09:59:31 UTC
On HiDpi displays we need to scale the thumbnails of photos and collections.
Created attachment 272662 [details] [review] base-item: Don't leak the unrendered emblemed icon
Created attachment 272663 [details] [review] base-item: Clean up the pixbuf loading code
Created attachment 272664 [details] [review] Skip icon-less documents for collection icons and effects
Created attachment 272665 [details] [review] application: Implement get_scale_factor
Created attachment 272666 [details] [review] Scale the icons for HiDpi displays
The patches are based on the corresponding ones from gnome-documents. My conclusion is that album icons are better with these patches, but thumbnails generated locally don't benefit because GNOME_DESKTOP_THUMBNAIL_SIZE_LARGE is set to 256 pixels and that is our base size. So scaling them leads to loss in image quality. Maybe it is time to introduce a SIZE_LARGE_HIDPI or something? For what it is worth, gnome-documents uses 48x48 or 128x128 thumbnails depending on whether it is a list or grid view, and it moved from creating SIZE_NORMAL to SIZE_LARGE thumbnails to accommodate HiDpi. Testing on real HiDpi hardware is welcome because I was only trying these out with GDK_SCALE=2.
I am going to merge these now so that they are part of 3.12.1. I hope that we can get some real world feedback that way.
Review of attachment 272662 [details] [review]: Committed.
Review of attachment 272663 [details] [review]: Committed.
Review of attachment 272664 [details] [review]: Committed.
Review of attachment 272665 [details] [review]: Committed.
Review of attachment 272666 [details] [review]: Committed.
Created attachment 274348 [details] [review] [gnome-3-12] application: Implement get_scale_factor