After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 726903 - Scale the thumbnails on HiDpi displays
Scale the thumbnails on HiDpi displays
Status: RESOLVED FIXED
Product: gnome-photos
Classification: Applications
Component: general
3.11.x
Other All
: Normal enhancement
: ---
Assigned To: GNOME photos maintainer(s)
GNOME photos maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2014-03-23 00:10 UTC by Debarshi Ray
Modified: 2014-04-15 09:59 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
base-item: Don't leak the unrendered emblemed icon (719 bytes, patch)
2014-03-23 00:17 UTC, Debarshi Ray
committed Details | Review
base-item: Clean up the pixbuf loading code (8.66 KB, patch)
2014-03-23 00:18 UTC, Debarshi Ray
committed Details | Review
Skip icon-less documents for collection icons and effects (3.03 KB, patch)
2014-03-23 00:18 UTC, Debarshi Ray
committed Details | Review
application: Implement get_scale_factor (5.42 KB, patch)
2014-03-23 00:20 UTC, Debarshi Ray
committed Details | Review
Scale the icons for HiDpi displays (9.00 KB, patch)
2014-03-23 00:20 UTC, Debarshi Ray
committed Details | Review
[gnome-3-12] application: Implement get_scale_factor (5.71 KB, patch)
2014-04-15 09:59 UTC, Debarshi Ray
committed Details | Review

Description Debarshi Ray 2014-03-23 00:10:18 UTC
On HiDpi displays we need to scale the thumbnails of photos and collections.
Comment 1 Debarshi Ray 2014-03-23 00:17:38 UTC
Created attachment 272662 [details] [review]
base-item: Don't leak the unrendered emblemed icon
Comment 2 Debarshi Ray 2014-03-23 00:18:11 UTC
Created attachment 272663 [details] [review]
base-item: Clean up the pixbuf loading code
Comment 3 Debarshi Ray 2014-03-23 00:18:57 UTC
Created attachment 272664 [details] [review]
Skip icon-less documents for collection icons and effects
Comment 4 Debarshi Ray 2014-03-23 00:20:18 UTC
Created attachment 272665 [details] [review]
application: Implement get_scale_factor
Comment 5 Debarshi Ray 2014-03-23 00:20:51 UTC
Created attachment 272666 [details] [review]
Scale the icons for HiDpi displays
Comment 6 Debarshi Ray 2014-03-23 01:10:58 UTC
The patches are based on the corresponding ones from gnome-documents. My conclusion is that album icons are better with these patches, but thumbnails generated locally don't benefit because GNOME_DESKTOP_THUMBNAIL_SIZE_LARGE is set to 256 pixels and that is our base size. So scaling them leads to loss in image quality. Maybe it is time to introduce a SIZE_LARGE_HIDPI or something?

For what it is worth, gnome-documents uses 48x48 or 128x128 thumbnails depending on whether it is a list or grid view, and it moved from creating SIZE_NORMAL to SIZE_LARGE thumbnails to accommodate HiDpi.

Testing on real HiDpi hardware is welcome because I was only trying these out with GDK_SCALE=2.
Comment 7 Debarshi Ray 2014-04-15 09:41:54 UTC
I am going to merge these now so that they are part of 3.12.1. I hope that we can get some real world feedback that way.
Comment 8 Debarshi Ray 2014-04-15 09:42:29 UTC
Review of attachment 272662 [details] [review]:

Committed.
Comment 9 Debarshi Ray 2014-04-15 09:43:23 UTC
Review of attachment 272663 [details] [review]:

Committed.
Comment 10 Debarshi Ray 2014-04-15 09:43:58 UTC
Review of attachment 272664 [details] [review]:

Committed.
Comment 11 Debarshi Ray 2014-04-15 09:44:33 UTC
Review of attachment 272665 [details] [review]:

Committed.
Comment 12 Debarshi Ray 2014-04-15 09:45:02 UTC
Review of attachment 272666 [details] [review]:

Committed.
Comment 13 Debarshi Ray 2014-04-15 09:59:31 UTC
Created attachment 274348 [details] [review]
[gnome-3-12] application: Implement get_scale_factor