After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 726885 - Make the thumbnailing robust against theme failures
Make the thumbnailing robust against theme failures
Status: RESOLVED FIXED
Product: gnome-documents
Classification: Core
Component: general
3.10.x
Other All
: Normal normal
: ---
Assigned To: GNOME documents maintainer(s)
GNOME documents maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2014-03-22 15:35 UTC by Debarshi Ray
Modified: 2014-03-25 13:03 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
documents: Make the emblem rendering robust against theme failures (1.13 KB, patch)
2014-03-22 15:37 UTC, Debarshi Ray 		committed Details | Review
documents: Skip icon-less documents when creating collection icons (1019 bytes, patch)
2014-03-22 18:35 UTC, Debarshi Ray 		none Details | Review
documents: Skip icon-less documents for collection icons and effects (1.26 KB, patch)
2014-03-22 19:11 UTC, Debarshi Ray 		accepted-commit_after_freeze Details | Review
documents: Skip icon-less documents for collection icons and effects (1.67 KB, patch)
2014-03-22 19:25 UTC, Debarshi Ray 		committed Details | Review

Description Debarshi Ray 2014-03-22 15:35:41 UTC 
After the changes in commit 54aa0abb6f10bf3dc3068918bcc96128d1a45433 , the emblemed pixbuf will be NULL if gtk_icon_info_load_icon failed to render it. We should continue to fallback to the unemblemed pixbuf in these cases.
Comment 1 Debarshi Ray 2014-03-22 15:37:48 UTC 
Created attachment 272633 [details] [review]
documents: Make the emblem rendering robust against theme failures
Comment 2 Debarshi Ray 2014-03-22 18:35:50 UTC 
Created attachment 272650 [details] [review]
documents: Skip icon-less documents when creating collection icons
Comment 3 Debarshi Ray 2014-03-22 19:11:26 UTC 
Created attachment 272651 [details] [review]
documents: Skip icon-less documents for collection icons and effects
Comment 4 Cosimo Cecchi 2014-03-22 19:23:39 UTC 
Review of attachment 272633 [details] [review]:

Looks good
Comment 5 Cosimo Cecchi 2014-03-22 19:23:50 UTC 
Review of attachment 272651 [details] [review]:

Sure
Comment 6 Debarshi Ray 2014-03-22 19:25:04 UTC 
Created attachment 272652 [details] [review]
documents: Skip icon-less documents for collection icons and effects
Comment 7 Cosimo Cecchi 2014-03-22 19:26:51 UTC 
Review of attachment 272652 [details] [review]:

OK