GNOME Bugzilla – Bug 726808
Void function should not return a value
Last modified: 2014-03-21 15:58:47 UTC
Created attachment 272532 [details] [review]
Fix "void function should not return a value" error for clang
I get this error when compiling cogl:
cogl-gst-video-sink.c:1668:3: error: void function 'cogl_gst_video_sink_get_natural_size' should not return a value [-Wreturn-type]
cogl_gst_video_sink_get_natural_size use g_return_val_if_fail in cogl-gst/cogl-gst-video-sink.c, and it should be changed to g_return_if_fail.
Review of attachment 272532 [details] [review]:
it's obviously correct.
Reviewed-by: Emmanuele Bassi <firstname.lastname@example.org>
Argh, I somehow failed to notice that you had attached a patch and I just pushed a different one:
Sorry about that. Thanks for the bug report.