After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 726808 - Void function should not return a value
Void function should not return a value
Status: RESOLVED FIXED
Product: cogl
Classification: Platform
Component: general
git master
Other FreeBSD
: Normal normal
: ---
Assigned To: Cogl maintainer(s)
Cogl maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2014-03-21 01:52 UTC by Ting-Wei Lan
Modified: 2014-03-21 15:58 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Fix "void function should not return a value" error for clang (758 bytes, patch)
2014-03-21 01:52 UTC, Ting-Wei Lan 		reviewed Details | Review

Description Ting-Wei Lan 2014-03-21 01:52:05 UTC 
Created attachment 272532 [details] [review]
Fix "void function should not return a value" error for clang

I get this error when compiling cogl:

cogl-gst-video-sink.c:1668:3: error: void function 'cogl_gst_video_sink_get_natural_size' should not return a value [-Wreturn-type]

cogl_gst_video_sink_get_natural_size use g_return_val_if_fail in cogl-gst/cogl-gst-video-sink.c, and it should be changed to g_return_if_fail.
Comment 1 Emmanuele Bassi (:ebassi) 2014-03-21 13:55:34 UTC 
Review of attachment 272532 [details] [review]:

it's obviously correct.

Reviewed-by: Emmanuele Bassi <ebassi@gnome.org>
Comment 2 Neil Roberts 2014-03-21 15:58:47 UTC 
Argh, I somehow failed to notice that you had attached a patch and I just pushed a different one:

https://git.gnome.org/browse/cogl/commit/?h=cogl-1.18&id=a972024ed742bbcf9ab06dbce68a39ad4558c44e

Sorry about that. Thanks for the bug report.