GNOME Bugzilla – Bug 726807
crash on startup
Last modified: 2014-03-21 16:28:07 UTC
Created attachment 272531 [details] stacktrace I'm experiencing a segfault on startup with 3.11.92. It crashes in the device mapper code because rr_screen is not initialized early enough.
Created attachment 272553 [details] [review] common: Fix initialization of GsdDeviceMapper Commit a73c5903ac introduced async GnomeRRScreen initialization but didn't cover all initialization scenarios. In the lowlevel functions, g_return_if_fail() is there is no GnomeRRScreen yet, and in the higher level functions, just check for it not being NULL. After the screen initialization, _device_mapper_update_outputs() will be called, which will catch up mapping every previously added input device.
Created attachment 272556 [details] [review] common: Fix initialization of GsdDeviceMapper Commit a73c5903ac introduced async GnomeRRScreen initialization but didn't cover all initialization scenarios. In the lowlevel functions, g_return_if_fail() is called if there is no GnomeRRScreen yet, and in the higher level functions, just check for it not being NULL. After the screen initialization, _device_mapper_update_outputs() will be called, which will catch up mapping every previously added input device.
Review of attachment 272556 [details] [review]: If we just bail out when called to early, do we need to redo this work when the rr_screen appears ? is there a signal that the randr plugin can catch to try again ? Or is this already taken care of ?
the patch fixes the crash for me
Review of attachment 272556 [details] [review]: Looks good
A hard code freeze was allowed for this one, pushed to master. Attachment 272556 [details] pushed as faff64c - common: Fix initialization of GsdDeviceMapper