After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 726794 - Use a single-binary setup for DBus activation
Use a single-binary setup for DBus activation
Status: RESOLVED FIXED
Product: gnome-documents
Classification: Core
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: GNOME documents maintainer(s)
GNOME documents maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2014-03-20 19:54 UTC by Debarshi Ray
Modified: 2014-05-14 10:49 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Use a single-binary setup for DBus activation (5.08 KB, patch)
2014-03-21 08:32 UTC, Debarshi Ray 		needs-work Details | Review
Use a single-binary setup for DBus activation (5.21 KB, patch)
2014-05-14 10:47 UTC, Debarshi Ray 		committed Details | Review

Description Debarshi Ray 2014-03-20 19:54:34 UTC 
The multi-binary setup is just too inconvenient for anybody who is building the sources and not installing it system-wide. You have to start the service and the send the activation -- it becomes tiring after a while.

Lets use the --gapplication-service command line flag (introduced in GLib 2.39.3) and restore sanity.
Comment 1 Debarshi Ray 2014-03-21 08:32:54 UTC 
Created attachment 272546 [details] [review]
Use a single-binary setup for DBus activation

Attaching patch sent via email.
Comment 2 Debarshi Ray 2014-05-14 10:46:15 UTC 
Review of attachment 272546 [details] [review]:

Thanks for the patch Álvaro!

::: src/main.js
@@ +28,3 @@
         application.hold();
+    if (ARGV.length == 1)
+        ARGV.unshift('');

I think a slightly better thing would be to do what gnome-weather does:
[System.programInvocationName].concat(ARGV)
Comment 3 Debarshi Ray 2014-05-14 10:47:58 UTC 
Created attachment 276518 [details] [review]
Use a single-binary setup for DBus activation

I took the liberty to fix up your patch.
Comment 4 Debarshi Ray 2014-05-14 10:48:33 UTC 
Review of attachment 276518 [details] [review]:

Committed.