GNOME Bugzilla – Bug 726686
the input/output bar should be disabled when there are no device
Last modified: 2021-06-09 16:27:25 UTC
I've use an Levono's PC which have front and back panel. So there are 3 output jack, line out, speaker, headphone. And 2 input jack, line in and microphone. When we remove all the input devices, we found the input bar is still enabled. The original issue is from below link. https://bugs.launchpad.net/ubuntu/+source/unity-control-center/+bug/1291862 We fix it for 3.4.2 version, and we found the change seems fine to me and it looks like it should apply to upstream GNOME (the code seems similar in https://git.gnome.org/browse/gnome-control-center/plain/panels/sound/gvc-mixer-dialog.c)
Created attachment 272365 [details] [review] Here is the patch for input/output status update When there are no input/output devices, I'll disable the input/output bar. And when the last intpu/output device removed, we need call active_in(out)put_update function.
Created attachment 272367 [details] [review] update the g_warning to g_debug New patch to lower the log level for null device cause this is in fact a supported and expected scenario.
Review of attachment 272365 [details] [review]: Hi Bin, thanks for your work. This appearently is a raw diff, not a patch, and I couldn't apply it cleanly, for it lacks a commit message.
Review of attachment 272367 [details] [review]: This does not apply on top of the master branch anymore.
GNOME is going to shut down bugzilla.gnome.org in favor of gitlab.gnome.org. As part of that, we are mass-closing older open tickets in bugzilla.gnome.org which have not seen updates for a longer time (resources are unfortunately quite limited so not every ticket can get handled). If you can still reproduce the situation described in this ticket in a recent and supported software version, then please follow https://wiki.gnome.org/GettingInTouch/BugReportingGuidelines and create a new bug report at https://gitlab.gnome.org/GNOME/gnome-control-center/-/issues/ Thank you for your understanding and your help.