After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 726682 - 1.4.0 fails to build on Fedora 21 armv7hl due to vtable missing
1.4.0 fails to build on Fedora 21 armv7hl due to vtable missing
Status: RESOLVED FIXED
Product: gnome-commander
Classification: Other
Component: application
1.4.x
Other Linux
: Normal normal
: 1.4
Assigned To: GNOME Commander maintainer(s)
GNOME Commander maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2014-03-19 07:51 UTC by Mamoru TASAKA
Modified: 2014-03-19 14:43 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Patch tof fix undefined reference to vtable (781 bytes, patch)
2014-03-19 07:51 UTC, Mamoru TASAKA
none Details | Review

Description Mamoru TASAKA 2014-03-19 07:51:21 UTC
Created attachment 272361 [details] [review]
Patch tof fix undefined reference to vtable

Hello,

Released gcmd 1.4.0 fails to build on armv7hl , Fedora 21 (i686, x86_64 is okay for some reason?) due to "undefined reference for vtable" like:

builddir/build/BUILD/gnome-commander-1.4.0/_builddir/../src/gnome-cmd-con-device.cc:293: undefined reference to `vtable for GnomeCmdPlainPath'
gnome-cmd-con-device.o: In function `dev_open':
/builddir/build/BUILD/gnome-commander-1.4.0/_builddir/../src/gnome-cmd-con-device.cc:181: undefined reference to `vtable for GnomeCmdPlainPath'
gnome-cmd-file.o: In function `gnome_cmd_file_new_from_uri(GnomeVFSURI*)':
.....

Full log:
http://kojipkgs.fedoraproject.org//work/tasks/4991/6644991/build.log
Top URL:
http://koji.fedoraproject.org/koji/taskinfo?taskID=6644991

It seems that the definitions of the virtual functions in GnomeCmdPlainPath are done all with inline, and (while on i686 and so it seems okay) on armv7hl vtables is not generated, perhaps because of:
http://gcc.gnu.org/wiki/VerboseDiagnostics#undefined_reference_to_vtable_for_X

It seems that the attached patch fixes this build failure.
Comment 1 Uwe Scholz 2014-03-19 14:43:12 UTC
Hello Mamoru. I commited your patch. Thank you. The fix will go into
the next release, v1.4.1. Thank you for your bug report.