After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 726678 - align.padding_bottom should plus two to make height as 2 aligned.
align.padding_bottom should plus two to make height as 2 aligned.
Status: RESOLVED OBSOLETE
Product: GStreamer
Classification: Platform
Component: gst-libav
1.2.3
Other Windows
: Normal normal
: git master
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2014-03-19 05:43 UTC by Jian Li
Modified: 2018-11-03 12:56 UTC
See Also:
GNOME target: ---
GNOME version: ---


Description Jian Li 2014-03-19 05:43:06 UTC 
I found in gst_ffmpegviddec_decide_allocation(), align.padding_bottom is added 1 extra pixel padding to match libav buffer allocation sizes, this will make the padding_bottom to odd number. But when calculate each planes offset in fill_planes(), it will GST_ROUND_UP_2 (height) for I420 format.

This makes the calculated height by height + align.padding_top + align.padding_bottom not match with the plane offset. 

It will cause problem for showing video with v4l2 output, as the height is not match with the real video height, cause v4l2 calculate u/v offset incorrect, then cause video color is wrong.

So shall align.padding_bottom add 2 extra pixel to make the height an even number?

Patch is attached.
Comment 1 Nicolas Dufresne (ndufresne) 2018-01-27 19:06:36 UTC 
Forgot the patch ? What io-mode do you use?
Comment 2 GStreamer system administrator 2018-11-03 12:56:12 UTC 
-- GitLab Migration Automatic Message --

This bug has been migrated to freedesktop.org's GitLab instance and has been closed from further activity.

You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.freedesktop.org/gstreamer/gst-libav/issues/11.