After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 726676 - More GtkStack transition counterparts of OVER_UP_DOWN
More GtkStack transition counterparts of OVER_UP_DOWN
Status: RESOLVED FIXED
Product: gtk+
Classification: Platform
Component: Widget: Other
3.10.x
Other All
: Normal enhancement
: ---
Assigned To: gtk-bugs
gtk-bugs
Depends on:
Blocks:
 
 
Reported: 2014-03-19 03:51 UTC by Philip Chimento
Modified: 2014-05-02 21:16 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Minor refactor patch (9.62 KB, application/octet-stream)
2014-03-19 03:51 UTC, Philip Chimento 		  Details
New stack transitions (4.55 KB, patch)
2014-03-19 03:51 UTC, Philip Chimento 		needs-work Details | Review
Minor refactor patch (9.60 KB, patch)
2014-05-01 20:53 UTC, Philip Chimento 		committed Details | Review
New stack transitions (4.54 KB, patch)
2014-05-01 20:53 UTC, Philip Chimento 		committed Details | Review

Description Philip Chimento 2014-03-19 03:51:07 UTC 
Created attachment 272352 [details]
Minor refactor patch

Here's a patch that adds the three counterparts of GTK_STACK_TRANSITION_TYPE_OVER_UP_DOWN: OVER_DOWN_UP, OVER_LEFT_RIGHT, and OVER_RIGHT_LEFT.

I'd guess this is for 3.14 since API is frozen for 3.12, but I split it out into two patches: one refactor to increase readability when adding more stack transition types (which I'd like to do at some point) and one to add the actual new API. The refactor patch could go in if there's still time before the code freeze.
Comment 1 Philip Chimento 2014-03-19 03:51:31 UTC 
Created attachment 272353 [details] [review]
New stack transitions
Comment 2 Matthias Clasen 2014-03-20 10:54:32 UTC 
Do you have a concrete use case for these new modes ?
I don't want to keep adding more modes just 'for completeness'
Comment 3 Philip Chimento 2014-03-20 17:23:52 UTC 
I'd want to use OVER_LEFT_RIGHT for a "page"-type situation, where "turning the page" makes the widget slide off to the right, revealing the next widget which is stationary, and turning the page backwards does the opposite, so that pages appear to be stacked in order. The left-to-right direction fits more with the idea of "pages" than the up-down direction does.

I think if you have OVER_UP_DOWN and OVER_LEFT_RIGHT you might as well have the other two, but I do at least have a direct need for OVER_LEFT_RIGHT.
Comment 4 Matthias Clasen 2014-03-22 02:48:41 UTC 
Review of attachment 272353 [details] [review]:

ok. will have to wait until we branch
Comment 5 Matthias Clasen 2014-04-28 20:25:18 UTC 
Review of attachment 272353 [details] [review]:

Could your rebase this patch ? It doesn't apply cleanly anymore
Comment 6 Philip Chimento 2014-05-01 20:53:03 UTC 
Created attachment 275574 [details] [review]
Minor refactor patch
Comment 7 Philip Chimento 2014-05-01 20:53:38 UTC 
Created attachment 275575 [details] [review]
New stack transitions

Sure, here you go.
Comment 8 Matthias Clasen 2014-05-02 13:08:42 UTC 
Review of attachment 275574 [details] [review]:

nice
Comment 9 Matthias Clasen 2014-05-02 13:11:11 UTC 
Review of attachment 275575 [details] [review]:

ok