After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 726661 - support is:read and is:unread search operators
support is:read and is:unread search operators
Status: RESOLVED FIXED
Product: geary
Classification: Other
Component: search
master
Other Linux
: Normal normal
: 0.11.0
Assigned To: Geary Maintainers
Geary Maintainers
review
Depends on:
Blocks:
 
 
Reported: 2014-03-18 17:49 UTC by Charles Lindsay
Modified: 2016-05-05 14:35 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
add is: search operators (6.25 KB, patch)
2015-06-29 13:05 UTC, Matthew Wong
none Details | Review
add is: search operators (6.31 KB, patch)
2015-06-29 19:19 UTC, Matthew Wong
none Details | Review
add is: search operators, git format-patch (6.66 KB, patch)
2016-04-21 03:32 UTC, Matthew Wong
none Details | Review
add is: search operators, git format-patch (6.71 KB, patch)
2016-04-30 02:05 UTC, Michael Gratton
none Details | Review
Add docs for new search operators (1.07 KB, patch)
2016-04-30 02:05 UTC, Michael Gratton
none Details | Review

Description Charles Lindsay 2014-03-18 17:49:21 UTC
It would be nice to support various is: operators in search, like is:read and is:unread, is:starred, etc.
Comment 1 Beny 2014-10-16 16:32:03 UTC
Lack of search option for unreaded messages is for me a big issue too.
Is there any progress in adding that feature?
Comment 2 Jim Nelson 2014-10-20 18:02:11 UTC
Not at this time.  This would be a great project for somebody from the community to step forward and attack.
Comment 3 Matthew Wong 2015-06-29 13:05:02 UTC
Created attachment 306288 [details] [review]
add is: search operators

Implements is:read, is:unread & is:starred. Please have a look and/or give it a try.
Comment 4 Matthew Wong 2015-06-29 19:19:37 UTC
Created attachment 306318 [details] [review]
add is: search operators

Fixed iterator error + typo...
Comment 5 Robert Schroll 2015-07-01 16:47:53 UTC
Great to see this!  I don't have time to review right now.  If you don't hear from me in a week, I've forgotten about this, so please comment to remind me.
Comment 6 Matthew Wong 2015-07-10 20:48:31 UTC
Hi Robert, this is a reminder to review my patch(es).
Comment 7 Federico Bruni 2015-09-22 12:48:04 UTC
Matthew, I tried your patch on current master and I can only comment as a user.

It seems to work pretty good.
I see that the list of unread messages is not refreshed as you read a message. This is ok as long as you stay in the search folder. Maybe if you change folder and then go back to the search folder it should be refreshed?

I'm just nitpicking... From a user point of view this is already great.
Many thanks for your contribution!
Comment 8 Matthew Wong 2015-09-24 02:06:58 UTC
Hi Federico, I'm glad you are using this patch. :] I agree that the behavior when changing folders you describe is the most reasonable. For now, I'll try to get some idea of how that might be implemented, but I would rather wait until this patch is accepted (i.e. resolve what issues it may have) before I delve too deep.
Comment 9 Michael Gratton 2016-04-12 06:12:03 UTC
Hey Matthew,

I'm keen to land this patch also - I will have a look at it, but let me know if you think it is good to land and please attach a version using `git format-patch` if you can.

Thanks!
Comment 10 Matthew Wong 2016-04-21 03:32:17 UTC
Created attachment 326467 [details] [review]
add is: search operators, git format-patch

I am happy with this patch as well. I am not sure if I need to do anything about my two patches touching the same code, I made them parallel in two different branches I think.
Comment 11 Michael Gratton 2016-04-24 00:44:36 UTC
Thanks for the updated patch. There is indeed a slight conflict when merging both this and the patch for Bug 749938, also we need the docs updated to reflect the new operators.

I think we can definitely land a new patch based off the work in Bug 749938,  and that includes an update for the docs in help/C/search.page.

For that help doc, simply adding a new table row for each of the new operators in alphabetical order, with a similar wording as the existing ones would be fine.
Comment 12 Michael Gratton 2016-04-30 02:05:11 UTC
Created attachment 327062 [details] [review]
add is: search operators, git format-patch

Refreshed the patch to apply to current master.
Comment 13 Michael Gratton 2016-04-30 02:05:47 UTC
Created attachment 327063 [details] [review]
Add docs for new search operators
Comment 14 Michael Gratton 2016-05-04 02:46:26 UTC
Adam, I think this is good to commit, ta.
Comment 15 Adam Dingle 2016-05-05 12:24:50 UTC
Pushed both patches to master.  Closing.
Comment 16 Federico Bruni 2016-05-05 14:35:31 UTC
... and is:starred too (not mentioned in the issue title)
I'd been waiting for this feature for a long time. Thanks!