GNOME Bugzilla – Bug 726661
support is:read and is:unread search operators
Last modified: 2016-05-05 14:35:31 UTC
It would be nice to support various is: operators in search, like is:read and is:unread, is:starred, etc.
Lack of search option for unreaded messages is for me a big issue too. Is there any progress in adding that feature?
Not at this time. This would be a great project for somebody from the community to step forward and attack.
Created attachment 306288 [details] [review] add is: search operators Implements is:read, is:unread & is:starred. Please have a look and/or give it a try.
Created attachment 306318 [details] [review] add is: search operators Fixed iterator error + typo...
Great to see this! I don't have time to review right now. If you don't hear from me in a week, I've forgotten about this, so please comment to remind me.
Hi Robert, this is a reminder to review my patch(es).
Matthew, I tried your patch on current master and I can only comment as a user. It seems to work pretty good. I see that the list of unread messages is not refreshed as you read a message. This is ok as long as you stay in the search folder. Maybe if you change folder and then go back to the search folder it should be refreshed? I'm just nitpicking... From a user point of view this is already great. Many thanks for your contribution!
Hi Federico, I'm glad you are using this patch. :] I agree that the behavior when changing folders you describe is the most reasonable. For now, I'll try to get some idea of how that might be implemented, but I would rather wait until this patch is accepted (i.e. resolve what issues it may have) before I delve too deep.
Hey Matthew, I'm keen to land this patch also - I will have a look at it, but let me know if you think it is good to land and please attach a version using `git format-patch` if you can. Thanks!
Created attachment 326467 [details] [review] add is: search operators, git format-patch I am happy with this patch as well. I am not sure if I need to do anything about my two patches touching the same code, I made them parallel in two different branches I think.
Thanks for the updated patch. There is indeed a slight conflict when merging both this and the patch for Bug 749938, also we need the docs updated to reflect the new operators. I think we can definitely land a new patch based off the work in Bug 749938, and that includes an update for the docs in help/C/search.page. For that help doc, simply adding a new table row for each of the new operators in alphabetical order, with a similar wording as the existing ones would be fine.
Created attachment 327062 [details] [review] add is: search operators, git format-patch Refreshed the patch to apply to current master.
Created attachment 327063 [details] [review] Add docs for new search operators
Adam, I think this is good to commit, ta.
Pushed both patches to master. Closing.
... and is:starred too (not mentioned in the issue title) I'd been waiting for this feature for a long time. Thanks!