After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 726649 - keyboard: not all xkb grp: options are dropped
keyboard: not all xkb grp: options are dropped
Status: RESOLVED FIXED
Product: gnome-settings-daemon
Classification: Core
Component: keyboard
unspecified
Other All
: Normal normal
: ---
Assigned To: Rui Matos
gnome-settings-daemon-maint
Depends on:
Blocks:
 
 
Reported: 2014-03-18 17:10 UTC by Роман Донченко
Modified: 2014-04-08 13:28 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
keyboard: Fix consecutive xkb grp: options not being stripped (1014 bytes, patch)
2014-03-19 12:53 UTC, Rui Matos
committed Details | Review

Description Роман Донченко 2014-03-18 17:10:30 UTC
The patch from bug 709085 has a bug in the strip_xkb_option function, which causes it to sometimes keep some of the prefixed options in the list. Here's a trivial (and untested!) patch:

diff --git a/plugins/keyboard/gsd-keyboard-manager.c b/plugins/keyboard/gsd-keyboard-manager.c
index 7e876fe..d8ff930 100644
--- a/plugins/keyboard/gsd-keyboard-manager.c
+++ b/plugins/keyboard/gsd-keyboard-manager.c
@@ -875,8 +875,9 @@ strip_xkb_option (gchar       **options,
                         g_free (*p);
                         *p = options[last];
                         options[last] = NULL;
+                } else {
+                        p += 1;
                 }
-                p += 1;
         }
 }
Comment 1 Rui Matos 2014-03-19 12:53:10 UTC
Created attachment 272379 [details] [review]
keyboard: Fix consecutive xkb grp: options not being stripped

--

Thanks for the patch, looks fine. We are in code freeze now so I'll
push it for 3.12.1.
Comment 2 Rui Matos 2014-04-08 13:28:16 UTC
Attachment 272379 [details] pushed as fc3676f - keyboard: Fix consecutive xkb grp: options not being stripped