GNOME Bugzilla – Bug 726649
keyboard: not all xkb grp: options are dropped
Last modified: 2014-04-08 13:28:20 UTC
The patch from bug 709085 has a bug in the strip_xkb_option function, which causes it to sometimes keep some of the prefixed options in the list. Here's a trivial (and untested!) patch: diff --git a/plugins/keyboard/gsd-keyboard-manager.c b/plugins/keyboard/gsd-keyboard-manager.c index 7e876fe..d8ff930 100644 --- a/plugins/keyboard/gsd-keyboard-manager.c +++ b/plugins/keyboard/gsd-keyboard-manager.c @@ -875,8 +875,9 @@ strip_xkb_option (gchar **options, g_free (*p); *p = options[last]; options[last] = NULL; + } else { + p += 1; } - p += 1; } }
Created attachment 272379 [details] [review] keyboard: Fix consecutive xkb grp: options not being stripped -- Thanks for the patch, looks fine. We are in code freeze now so I'll push it for 3.12.1.
Attachment 272379 [details] pushed as fc3676f - keyboard: Fix consecutive xkb grp: options not being stripped