After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 726643 - Fix problematic strokes in WiFi and Volume icons.
Fix problematic strokes in WiFi and Volume icons.
Status: RESOLVED FIXED
Product: adwaita-icon-theme
Classification: Core
Component: symbolic
unspecified
Other Linux
: Normal enhancement
: ---
Assigned To: Jakub Steiner
Depends on:
Blocks:
 
 
Reported: 2014-03-18 15:53 UTC by Reda Lazri
Modified: 2014-03-19 16:16 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
bake masks and path strokes for wifi and volume icons (193.77 KB, patch)
2014-03-19 11:59 UTC, Jakub Steiner
none Details | Review

Description Reda Lazri 2014-03-18 15:53:36 UTC
Patch attached.
Comment 2 Jakub Steiner 2014-03-19 11:41:51 UTC
I understand why you'd want to center the dots on the acquiring icons, but you can't do it in the trivial fuzziness-inducting way. You'd need to play with scale to make that happen.
Comment 3 Jakub Steiner 2014-03-19 11:47:55 UTC
Also for future patches, note that all objects (groups) hold the naming required for naming the exported files. You cleaned/duplicated over all of them.
Comment 4 Jakub Steiner 2014-03-19 11:59:36 UTC
Created attachment 272377 [details] [review]
bake masks and path strokes for wifi and volume icons

- avoids rendering issues for large canvas
Comment 5 Reda Lazri 2014-03-19 16:16:09 UTC
Yes, I knew about the naming but I forgot to keep them somehow. :(
And for the three dots, it's aligned properly in the 'stencils' file in Github, I didn't notice that the icon is a 1px larger on GNOME Git and didn't check. Sorry. :P

Did you find out why the patch was huge?