After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 726637 - eglglessinnk: unable to create EGL window on RPI
eglglessinnk: unable to create EGL window on RPI
Status: RESOLVED OBSOLETE
Product: GStreamer
Classification: Platform
Component: gst-plugins-bad
0.10.x
Other Linux
: Normal critical
: git master
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2014-03-18 15:13 UTC by scerveau
Modified: 2014-05-26 09:27 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Fix eglglessink RPI patch (1.54 KB, patch)
2014-03-18 15:20 UTC, scerveau
none Details | Review
Fix eglglessink RPI patch (1.17 KB, patch)
2014-03-19 10:56 UTC, scerveau
needs-work Details | Review

Description scerveau 2014-03-18 15:13:36 UTC
The eglglessink is not working on RPI platform with branch gst-plugins-bad 0.10 branch.
I get an error: Could not create window.
I was testing with gst-launch-0.10 videotestsrc ! eglglessink
Comment 1 scerveau 2014-03-18 15:20:56 UTC
Created attachment 272282 [details] [review]
Fix eglglessink RPI patch

This patch allows to make eglglessink work on RPI
Comment 2 scerveau 2014-03-19 10:56:12 UTC
Created attachment 272369 [details] [review]
Fix eglglessink RPI patch
Comment 3 Reynaldo H. Verdejo Pinochet 2014-03-27 22:12:41 UTC
Review of attachment 272369 [details] [review]:

Patch is not correct. Also, I didn't quite get your reference
to 1.0 in the commit message, the code in question is equivalent
in both branches (although the actual window creation code might have
changed, I didn't check).

::: ext/eglgles/gsteglglessink.c
@@ +1120,3 @@
     GST_INFO_OBJECT (eglglessink,
         "No window. Will attempt internal window creation");
+    if(!gst_egl_adaptation_create_native_window(eglglessink->egl_context, width, height, &eglglessink->own_window_data)) {

This is not correct. _create_window() will call gst_egl_adaptation_create_window()
without needing any shortcuts if create_window prop is not FALSE. If you are not
setting it to FALSE explicitly (default is TRUE IIRC) and the window creation
code works with your setup, then the correct fix is elsewhere.
Comment 4 Nicolas Dufresne (ndufresne) 2014-05-24 19:31:19 UTC
I'm sorry, but eglglessink has been removed from GStreamer and replaced with glimagesink. Additionally, GStreamer 0.10 is no longer maintained by the GStreamer community, which means patches are no longer accepted for that version.

Thanks for reporting and taking the time to provide patches.
Comment 5 scerveau 2014-05-26 09:03:41 UTC
Dear Nicolas,

Thank you for your answer.
I cant see anywhere glimagesink in gst-plugins-bad.
Concerning my patch, i was needing gstreamer 0.10 on RPI and unable to make it work correctly. That's why i proposed this patch. I dont think, i'm alone in this case.
I'm ready to make a proper patch according ro Reynaldo, but Reynaldo could you precise, i dont get your point.
Best regards.
Comment 6 Sebastian Dröge (slomo) 2014-05-26 09:12:59 UTC
glimagesink is in gst-plugins-bad 1.3 and newer, and eglglessink was removed there. It was only meant an iterim solution until glimagesink is ready.

GStreamer 0.10 is no longer supported, and you should use at least 1.2. That version also has proper support for the RPi, and 1.3 even better RPi support.

If there's still a problem in 1.2, please provide a patch against eglglessink from that version but please also try glimagesink from 1.3.
Comment 7 scerveau 2014-05-26 09:27:24 UTC
Thank you for your answer.
I will use my patch locally.
Best regards.