After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 726619 - Should distribute Copying with tarball
Should distribute Copying with tarball
Status: RESOLVED FIXED
Product: gnome-sound-recorder
Classification: Other
Component: General
3.11.x
Other All
: Normal normal
: ---
Assigned To: gnome-sound-recorder maintainer(s)
gnome-sound-recorder maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2014-03-18 10:28 UTC by David King
Modified: 2014-03-26 13:37 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
rename and distribute COPYING and AUTHORS (88.51 KB, patch)
2014-03-18 10:29 UTC, David King
none Details | Review

Description David King 2014-03-18 10:28:24 UTC
Including the full text of the licence is important, so it should be distributed with the tarball. It would also be better to use the standard name COPYING. AUTHORS should be treated similarly.
Comment 1 David King 2014-03-18 10:29:42 UTC
Created attachment 272261 [details] [review]
rename and distribute COPYING and AUTHORS
Comment 2 Meg Ford 2014-03-19 14:19:27 UTC
Can you explain the difference between this and what I am currently doing? afaik the COPYING and AUTHORS files are being included in the tarballs and the files you are providing are identical to the ones that are being included. What am I not understanding?
Comment 3 David King 2014-03-19 14:31:08 UTC
Of course! The files are indeed identical, the patch is just to rename them to the ALLCAPS variant. automake automatically distributes several files, including README, NEWS and so on. However, the files have to be named exactly as automake expects if they are to be distributed. "Copying" and "Authors" are not the capitalization that automake expects, and are therefore not distributed in the gnome-sound-recorder tarballs. You can verify this by checking the tarball at https://download.gnome.org/sources/gnome-sound-recorder/3.11/gnome-sound-recorder-3.11.91.1.tar.xz (for example); there is neither a "Copying" nor a "COPYING".

The reason that I discovered this is that I submitted a Fedora package review request for gnome-sound-recorder, as I was surprised that it was not already included:

https://bugzilla.redhat.com/show_bug.cgi?id=1077810

Having a licence that is not inside the tarball makes this a bit complicated.

My longer-term suggestion would be to drop the "foreign" argument to automake (in configure.ac), which then requires AUTHORS and COPYING to be present. However, this also requires a ChangeLog. Most projects generate that file at distribution time, and have a dummy file in the tree. Although a separate topic, but I would be happy to write a Makefile target to do that.
Comment 4 Meg Ford 2014-03-19 14:48:12 UTC
I see, thanks for explaining. I assume it's too late to do this for 3.12, is that correct?
Comment 5 David King 2014-03-19 14:52:06 UTC
A release was scheduled for this past Monday (17th, 3.11.92), which would be the start of hard code freeze. In my opinion, this would classify as a bugfix, but you can ask release-team@gnome.org for an exception (and possibly to allow a late release to get in for 3.11.92) and I am sure it would be fine. You can see a bit more information about what might break the freeze, and how to request an exception at:

https://wiki.gnome.org/ReleasePlanning/RequestingFreezeBreaks
Comment 6 Meg Ford 2014-03-19 14:54:50 UTC
Thanks, I need to request a late release anyway because the hardware issues I had with wacom prevented me from releasing 3.11.92 on time. I'll ask the release team.
Comment 7 David King 2014-03-26 13:37:46 UTC
The files are in the tarballs now, thanks!