After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 726593 - replace-dialog: fix corner-case button sensitivity
replace-dialog: fix corner-case button sensitivity
Status: RESOLVED FIXED
Product: gedit
Classification: Applications
Component: search and replace
unspecified
Other All
: Normal minor
: ---
Assigned To: Gedit maintainers
Gedit maintainers
Depends on:
Blocks:
 
 
Reported: 2014-03-18 01:01 UTC by Michael Catanzaro
Modified: 2014-03-30 14:38 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
replace-dialog: fix corner-case button sensitivity (1.79 KB, patch)
2014-03-18 01:02 UTC, Michael Catanzaro 		committed Details | Review

Description Michael Catanzaro 2014-03-18 01:01:08 UTC 
The Replace All, Replace, and Find buttons can be insensitive as the result of a previous regex error even after regex search is disabled.
Comment 1 Michael Catanzaro 2014-03-18 01:02:07 UTC 
Created attachment 272219 [details] [review]
replace-dialog: fix corner-case button sensitivity

If the regular expression checkbutton is checked, the search entry
contains an invalid regular expression, and the user presses Find or
Replace All, all response buttons correctly become insensitive. Now, if
the user unchecks the regex checkbutton, the error should be cleared and
the responses should become sensitive so that he can search again. This
wasn't happening.
Comment 2 Sébastien Wilmet 2014-03-18 12:12:17 UTC 
Review of attachment 272219 [details] [review]:

Thanks, the commit looks good. Since it is not critical, it can be pushed after the freeze.
Comment 3 Paolo Borelli 2014-03-30 14:37:52 UTC 
Comment on attachment 272219 [details] [review]
replace-dialog: fix corner-case button sensitivity

pushed
Comment 4 Paolo Borelli 2014-03-30 14:38:04 UTC 
This problem has been fixed in the development version. The fix will be available in the next major software release. Thank you for your bug report.