Bug 726580 – Don't escape blockquote markup in non-sgml mode

After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.

Bug 726580 - Don't escape blockquote markup in non-sgml mode


Summary:	Don't escape blockquote markup in non-sgml mode


Status:	RESOLVED FIXED

Product:	gtk-doc
Classification:	Platform
Component:	general
Version:	unspecified
Hardware:	Other All

Importance:	Normal normal
Target Milestone:	---
Assigned To:	gtk-doc maintainers
QA Contact:	gtk-doc maintainers

URL:
Whiteboard:

Depends on:
Blocks:

Reported:	2014-03-17 21:06 UTC by William Jon McCann
Modified:	2014-04-02 20:44 UTC

See Also:
GNOME target:	---
GNOME version:	---

Attachments
Don't escape blockquote markup in non-sgml mode (1.34 KB, patch) 2014-03-17 21:06 UTC, William Jon McCann	committed	Details \| Review

Description William Jon McCann 2014-03-17 21:06:48 UTC

Blockquotes don't work in non-sgml mode now.

Comment 1 William Jon McCann 2014-03-17 21:06:49 UTC

Created attachment 272209 [details] [review]
Don't escape blockquote markup in non-sgml mode

Escaping > etc unconditionally breaks markdown in non-sgml mode.
We should do the escaping the same in both modes.

Comment 2 Stefan Sauer (gstreamer, gtkdoc dev) 2014-03-20 20:41:47 UTC

Review of attachment 272209 [details] [review]:

Thanks, just a small nit.

::: gtkdoc-mkdb.in
@@ +2767,3 @@
         # For the simple non-sgml mode, convert to entities everywhere.
+
+        $text =~ s/&(?![a-zA-Z#]+;)/&amp;/g;        # Do this first, or the others get messed up.

could you please also put the comment above and say what it does, e.g.
# First convert free standing & to &amp;

Comment 3 Matthias Clasen 2014-03-28 20:05:45 UTC

Attachment 272209 [details] pushed as b53854d - Don't escape blockquote markup in non-sgml mode

Comment 4 Stefan Sauer (gstreamer, gtkdoc dev) 2014-03-31 10:23:31 UTC

Could you please also apply the suggestion I made?

Comment 5 Matthias Clasen 2014-03-31 21:52:22 UTC

I think I did ?

Comment 6 Stefan Sauer (gstreamer, gtkdoc dev) 2014-04-02 20:44:01 UTC

Sorry, diff reading skillz degraded :/