GNOME Bugzilla – Bug 726571
should use Makefile.introspection
Last modified: 2018-05-22 05:04:17 UTC
Hi. The hand-rolled rules in the Makefile are missing some things that the m4 macros have -- particularly support for a non-standard libtool path. See also: https://fedorahosted.org/libosinfo/ticket/11 On OpenBSD this allows using the OS provided libtool(1) (https://bugzilla.gnome.org/show_bug.cgi?id=726518) and fix the build. This is needed for at least gstreamer, gst-plugins-base and gst-plugins-bad. No patch sorry, I am not familiar enough with this... :-/
Created attachment 273901 [details] [review] do not hardcode libtool path FWIW this patch does the trick.
Hi. Any opinion on this? Thanks.
I think we should use Makefile.introspection if that's possible somehow. Can you provide a patch for that instead?
Should be fine I guess: commit 3e24bbefba9889c621d35234143271d6f0453326 Author: Antoine Jacoutot <ajacoutot@gnome.org> Date: Wed Apr 9 16:44:07 2014 +0200 libs: g-ir-scanner: do not hardcode libtool path https://bugzilla.gnome.org/show_bug.cgi?id=726571 Will see what the build bots say and leave it open for -base.
There's another bug to use Makefile.introspection, but I think there was some stuff missing there, and it feels like a change I'd rather push at the beginning of a cycle than towards the end.
(In reply to comment #4) > Should be fine I guess: > > commit 3e24bbefba9889c621d35234143271d6f0453326 > Author: Antoine Jacoutot <ajacoutot@gnome.org> > Date: Wed Apr 9 16:44:07 2014 +0200 > > libs: g-ir-scanner: do not hardcode libtool path > > https://bugzilla.gnome.org/show_bug.cgi?id=726571 > > > Will see what the build bots say and leave it open for -base. Awesome, thanks Tim. Note that as mentioned in my initial post, the same should be done in plugins-bad and plugins-base. Do you want a patch or I suppose it'd go faster if you take care of it yourself? Thanks.
Created attachment 274655 [details] [review] plugins-base: do not hardcode libtool path Patch for plugins-base.
Created attachment 274656 [details] [review] plugins-bad: do not hardcode libtool path Patch for plugins-bad.
Hi Tim. Any other input regarding the plugins-base and plugins-bad patches? Thanks.
*** Bug 750296 has been marked as a duplicate of this bug. ***
Thanks for the bug report and the patches. We're moving away from autotools towards Meson, so I'm going to close this as I don't think it makes sense to change this at this point, sorry. Please give the Meson port a spin on OpenBSD and let us know if there are any issues with that, thanks!
The gst-libs/gst/gl/Makefile.am in -base is skipped in the previous patch.
Pushed a fix for that. Thanks !