After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 726535 - Budget BarChart Report - add option to change to a line chart
Budget BarChart Report - add option to change to a line chart
Status: RESOLVED FIXED
Product: GnuCash
Classification: Other
Component: Reports
2.6.2
Other Linux
: Normal enhancement
: future
Assigned To: gnucash-reports-maint
gnucash-reports-maint
Depends on:
Blocks:
 
 
Reported: 2014-03-17 14:00 UTC by Carsten Rinke
Modified: 2018-06-29 23:28 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
patch that depends on Bug726449 (5.38 KB, patch)
2014-03-17 14:06 UTC, Carsten Rinke
needs-work Details | Review
Patch to be applied on GnuCash 2.6.3 (7.68 KB, patch)
2014-06-11 06:04 UTC, Carsten Rinke
needs-work Details | Review
patch to be applied on master commit ea2389f0932beae.. (7.84 KB, patch)
2014-06-19 09:24 UTC, Carsten Rinke
committed Details | Review

Description Carsten Rinke 2014-03-17 14:00:01 UTC
When starting to use the Budget Barchart report, I found it harder to read than other budget report that I had seen that were presented as line charts.

So this bug asks for an change of the Barchart report to also include a view of a line chart.
Comment 1 Carsten Rinke 2014-03-17 14:06:47 UTC
Created attachment 272166 [details] [review]
patch that depends on Bug726449

This is a simple solution proposal, based on the changes made in Bug726449.
It adds a check-box to the "General" options tab that can be activated to switch from a bar chart view to a line chart view.
Per default this box is unchecked, and the report will work as before.

A better solution is to rename the report to "Budget Chart" and implement a selection box instead of a checkbox to make user decide between bar- or line-chart.
On the other hand, the outcome is fairly the same, and I don't know if renaming of reports causes other side effects (e.g. backward compatibility to already saved report configuration).
Comment 2 Geert Janssens 2014-04-23 12:12:33 UTC
(In reply to comment #1)
> A better solution is to rename the report to "Budget Chart" and implement a
> selection box instead of a checkbox to make user decide between bar- or
> line-chart.
> On the other hand, the outcome is fairly the same, and I don't know if renaming
> of reports causes other side effects (e.g. backward compatibility to already
> saved report configuration).

I agree that your second proposal makes more sense from a user perspective. It's fairly counterintuitive that one needs to open a report called "Budget Bar Chart" and then change an option to get a line chart version instead.

Renaming the report will not have any effect on already saved report configurations. Saved reports are keyed off of the report ID, not the name (although the name is stored as well for historical reasons).

So as far as I'm concerned, please go ahead and do what is necessary to rename the report and add a combobox option.

Particularly since this is a feature enhancement and not a bug fix it will be applied to master only (to appear in 2.8 eventually).
Comment 3 Carsten Rinke 2014-06-11 06:04:46 UTC
Created attachment 278247 [details] [review]
Patch to be applied on GnuCash 2.6.3

new patch version

To be applied on plain 2.6.3.
I removed the dependency.
Comment 4 Geert Janssens 2014-06-18 15:59:17 UTC
Comment on attachment 278247 [details] [review]
Patch to be applied on GnuCash 2.6.3

Hi Carsten,

Thank you for your updated patch. The principle looks good but unfortunately it doesn't apply.

Your patch seems to be created based on code that doesn't have the jqplot-escape-string safety nets in place which were added for bug 726449.

Can you rebase your patch to the latest master and re-attach here ?

Thanks
Comment 5 Geert Janssens 2014-06-18 16:32:05 UTC
Hmm, I tried to apply the patch to a branch right before the patches from bug 726449 were applied and then rebased the resulting commit on master. This gave some merge conflicts which I *thought* were easy to resolve.

But the resulting report only works in barchart mode, not in linechart mode. I can't determine if this is due to a poor merge conflict resolution from my side or because there is still a bug in the code.

I'm using the budget test file that was attached to another budget related bug (the one regarding the inconsistent signs). In barchart format, I see some barcharts. For the linechart I get a completely empty report page. No title, nothing.

Can you check this ?

Thanks.
Comment 6 Carsten Rinke 2014-06-19 09:24:12 UTC
Created attachment 278748 [details] [review]
patch to be applied on master commit ea2389f0932beae..

Hi Geert,

here comes a patch that I have prepared from commit ea2389f0932beae..

Unfortunately I cannot check the result because I run into:

checking whether we are using the GNU C++ compiler... yes
checking whether g++ accepts -g... yes
checking dependency style of g++... gcc3
checking whether g++ supports C++11 features by default... no
checking whether g++ supports C++11 features with -std=gnu++11... no
checking whether g++ supports C++11 features with -std=gnu++0x... no
configure: error: *** A compiler with support for C++11 language features is required.
(Ubuntu 12.04:
  g++ --version:
  g++ (Ubuntu/Linaro 4.6.3-1ubuntu5) 4.6.3
)

So I just hope that it applies and works out of the box.

Otherwise:
Can you give me a hint what g++ version I'd need to install to get going?
Comment 7 Geert Janssens 2014-06-19 10:00:39 UTC
Comment on attachment 278748 [details] [review]
patch to be applied on master commit ea2389f0932beae..

Thanks for the quick update.

Your patch works fine so I clearly did something wrong when hand-correcting the merge conflicts I saw.

I have committed it to master. Good work!
Comment 8 Geert Janssens 2014-06-19 10:02:57 UTC
(In reply to comment #6)
> 
> Unfortunately I cannot check the result because I run into:
> 
> checking whether we are using the GNU C++ compiler... yes
> checking whether g++ accepts -g... yes
> checking dependency style of g++... gcc3
> checking whether g++ supports C++11 features by default... no
> checking whether g++ supports C++11 features with -std=gnu++11... no
> checking whether g++ supports C++11 features with -std=gnu++0x... no
> configure: error: *** A compiler with support for C++11 language features is
> required.
> (Ubuntu 12.04:
>   g++ --version:
>   g++ (Ubuntu/Linaro 4.6.3-1ubuntu5) 4.6.3
> )
> 
> So I just hope that it applies and works out of the box.
> 
> Otherwise:
> Can you give me a hint what g++ version I'd need to install to get going?
It appears g++ 4.7 is the first version that comes with C++11 support.

I don't know if that's available on Ubuntu 12.04 (LTS I presume?).

I'm working with g++ 4.8..2 on my Fedora 20 system.
Comment 9 John Ralls 2018-06-29 23:28:26 UTC
GnuCash bug tracking has moved to a new Bugzilla host. This bug has been copied to https://bugs.gnucash.org/show_bug.cgi?id=726535. Please update any external references or bookmarks.