After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 726500 - gear button is wider than tall
gear button is wider than tall
Status: RESOLVED FIXED
Product: gnome-disk-utility
Classification: Core
Component: general
3.11.x
Other Linux
: Normal normal
: ---
Assigned To: gnome-disk-utility-maint
gnome-disk-utility-maint
: 727169 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2014-03-17 10:17 UTC by Andreas Nilsson
Modified: 2014-03-27 17:08 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
screenshot (26.55 KB, image/png)
2014-03-17 10:17 UTC, Andreas Nilsson 		  Details
Drop unneeded margin inside image buttons (2.19 KB, patch)
2014-03-19 01:32 UTC, Matthias Clasen 		none Details | Review

Description Andreas Nilsson 2014-03-17 10:17:14 UTC 
Created attachment 272128 [details]
screenshot

Most gear buttons (nautilus, documents, totem etc.) are all as tall as wide, but this don't seem to be the case in Disks.
Comment 1 Matthias Clasen 2014-03-19 01:32:31 UTC 
Created attachment 272338 [details] [review]
Drop unneeded margin inside image buttons

These margins may have been needed before GTK+ was automatically
adding the image-button style class. Nowadays, they just make the
buttons non-square.
Comment 2 David Zeuthen (not reading bugmail) 2014-03-19 05:47:39 UTC 
Sounds good to me but I think you need to ask the release-team for permission. Once you get that permission, feel free to commit. Thanks!
Comment 3 David Zeuthen (not reading bugmail) 2014-03-19 05:51:05 UTC 
Btw, on my Fedora 20 system with GTK+ 3.10 this patch has the opposite effect; IOW, before the patch w/ 3.10 the buttons were nice and square and with the patch they're non-square.

So if you commit this, please raise the GTK+ dependency to 3.12 and manually check that it looks correct with 3.12. Thanks!
Comment 4 David Zeuthen (not reading bugmail) 2014-03-23 18:39:41 UTC 
Fixed in 3.12.0.
Comment 5 David Zeuthen (not reading bugmail) 2014-03-27 17:08:50 UTC 
*** Bug 727169 has been marked as a duplicate of this bug. ***