After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 726470 - tests: Add unit tests for sessionpool
tests: Add unit tests for sessionpool
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-rtsp-server
git master
Other All
: Normal enhancement
: 1.3.1
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2014-03-16 18:50 UTC by Sebastian Rasmussen
Modified: 2014-03-24 11:20 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Proposed patch adding unit tests for rtsp-session-pool (7.11 KB, patch)
2014-03-16 18:52 UTC, Sebastian Rasmussen 		none Details | Review

Description Sebastian Rasmussen 2014-03-16 18:50:50 UTC 
Previously the collection of all rtsp-server tests managed to exercise gst/rtsp-session-pool.c convering up to 47.6% of the lines. This patch adds a session-pool specific check test that raises the coverage to 90.5%.

The only drawback is that there is a ~5 second delay when running the test due to an implicit 5 second timeout in the GstRTSPSessions themselves.
Comment 1 Sebastian Rasmussen 2014-03-16 18:52:11 UTC 
Created attachment 272084 [details] [review]
Proposed patch adding unit tests for rtsp-session-pool
Comment 2 Wim Taymans 2014-03-24 11:20:46 UTC 
commit bfbf393925643f1c5c9b17d9cc5331f23ba321ec
Author: Sebastian Rasmussen <sebras@hotmail.com>
Date:   Sun Mar 16 19:45:26 2014 +0100

    tests: Add unit tests for sessionpool
    
    Fixes https://bugzilla.gnome.org/show_bug.cgi?id=726470