GNOME Bugzilla – Bug 726460
Cannot build documentation when NetworkManager is disabled
Last modified: 2014-05-28 20:08:57 UTC
Created attachment 272070 [details] [review] Fix documentation build problem when NetworkManager is disabled I got the following error when using --disable-networkmanager --enable-gtk-doc: gmake[4]: Entering directory `/home/lantw44/gnome/source/gnome-shell/docs/reference/shell' DOC Scanning header files DOC Introspecting gobjects .libs/shell-scan.o: In function `get_object_types': /home/lantw44/gnome/source/gnome-shell/docs/reference/shell/shell-scan.c:84: undefined reference to `shell_network_agent_get_type'
We should probably just remove shell-network-agent from the docs unconditionally.
(In reply to comment #1) > We should probably just remove shell-network-agent from the docs > unconditionally. Is the reason of removing it unconditionally that NetworkManager is not always available?
Just because ShellNetworkAgent is an internal implementation detail really, and it's not worth complicating our docs infrastructure for.
Created attachment 275065 [details] [review] [PATCH] build: Remove ShellNetworkAgent documentation It is only an internal implementation detail, and it also causes build problem when NetworkManager is disabled. https://bugzilla.gnome.org/show_bug.cgi?id=726460 --- docs/reference/shell/Makefile.am | 4 ++++ docs/reference/shell/shell-docs.sgml.in | 1 - 2 files changed, 4 insertions(+), 1 deletion(-)
Review of attachment 275065 [details] [review]: ::: docs/reference/shell/Makefile.am @@ +75,3 @@ +if !HAVE_NETWORKMANAGER +IGNORE_HFILES += shell-network-agent.h +endif The documentation is unconditionally not built, so the header shouldn't be excluded conditionally.
Created attachment 275073 [details] [review] [PATCH] build: Remove ShellNetworkAgent documentation It is only an internal implementation detail, and it also causes build problem when NetworkManager is disabled. https://bugzilla.gnome.org/show_bug.cgi?id=726460 --- docs/reference/shell/Makefile.am | 1 + docs/reference/shell/shell-docs.sgml.in | 1 - 2 files changed, 1 insertion(+), 1 deletion(-)
Review of attachment 275073 [details] [review]: LGTM