After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 726400 - NMPolicy: don't reject activating devices with incomplete IP config
NMPolicy: don't reject activating devices with incomplete IP config
Status: RESOLVED FIXED
Product: NetworkManager
Classification: Platform
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: NetworkManager maintainer(s)
NetworkManager maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2014-03-15 11:30 UTC by Giovanni Campagna
Modified: 2014-06-30 15:26 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
NMPolicy: don't reject activating devices with incomplete IP config (2.21 KB, patch)
2014-03-15 11:30 UTC, Giovanni Campagna 		none Details | Review

Description Giovanni Campagna 2014-03-15 11:30:34 UTC 
An activating device may have an IP config that is unrelated to
the current activation (for example if it comes from capturing
the existing config when NM is started), and that config might
not have a gateway, which would have NM ignore that the device
is activating until after DHCP.
Comment 1 Giovanni Campagna 2014-03-15 11:30:37 UTC 
Created attachment 271993 [details] [review]
NMPolicy: don't reject activating devices with incomplete IP config
Comment 2 Thomas Haller 2014-03-17 13:24:26 UTC 
ACK. This looks correct to me.
Comment 3 Giovanni Campagna 2014-03-17 15:21:30 UTC 
(In reply to comment #2)
> ACK. This looks correct to me.

I don't have commit access in Freedesktop, would you please push it for me?
Thanks!
Comment 4 Thomas Haller 2014-03-17 15:35:09 UTC 
(In reply to comment #3)
> (In reply to comment #2)
> > ACK. This looks correct to me.
> 
> I don't have commit access in Freedesktop, would you please push it for me?
> Thanks!

Sure, I just waiting what others have to say about it... soembody will take care of it.

Btw, thanks for your effort!! :)
Comment 5 Giovanni Campagna 2014-05-04 13:28:57 UTC 
Any update on this?
This is causing buggy behavior in gnome-shell 3.12, it would be nice to merge and then backport it.
Comment 6 Dan Winship 2014-06-24 18:46:15 UTC 
Yeah, this makes sense to me. Do we want to get it into 0.9.10?
Comment 7 Jiri Klimes 2014-06-30 14:55:18 UTC 
The patch seems right to me.