After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 726322 - App folders with only one app have the wrong size and position
App folders with only one app have the wrong size and position
Status: RESOLVED FIXED
Product: gnome-shell
Classification: Core
Component: overview
3.11.x
Other Linux
: Normal normal
: ---
Assigned To: gnome-shell-maint
gnome-shell-maint
3.12
Depends on:
Blocks:
 
 
Reported: 2014-03-14 10:40 UTC by Allan Day
Modified: 2014-03-17 09:46 UTC
See Also:
GNOME target: ---
GNOME version: 3.11/3.12

Attachments
screenshot (257.69 KB, image/png)
2014-03-14 10:40 UTC, Allan Day 		  Details
appDisplay: Improve icons of folders with few apps (1.86 KB, patch)
2014-03-14 15:04 UTC, Florian Müllner 		none Details | Review
appDisplay: Improve icons of folders with few apps (1.67 KB, patch)
2014-03-14 16:25 UTC, Florian Müllner 		committed Details | Review

Description Allan Day 2014-03-14 10:40:59 UTC 
Created attachment 271855 [details]
screenshot

This was observed on 3.11.91, after creating an app folder from Software. It looks quite bad.
Comment 1 Florian Müllner 2014-03-14 15:04:53 UTC 
Created attachment 271907 [details] [review]
appDisplay: Improve icons of folders with few apps

Folders use a 2x2 grid of the first 4 app icons as icon - if a folder
contains less apps, we currently skip the corresponding grid positions.
As a result, the overall size request may be smaller than the one for
other icons, making the folder icon look out of place.
Fix this by always using a full grid as folder icon, using dummy actors
as necessary.
Comment 2 Florian Müllner 2014-03-14 16:25:05 UTC 
Created attachment 271919 [details] [review]
appDisplay: Improve icons of folders with few apps

Rebased to master.
Comment 3 drago01 2014-03-14 22:55:09 UTC 
Review of attachment 271919 [details] [review]:

LG.
Comment 4 Florian Müllner 2014-03-14 23:25:36 UTC 
Attachment 271919 [details] pushed as 30fb2b0 - appDisplay: Improve icons of folders with few apps
Comment 5 Allan Day 2014-03-17 09:46:27 UTC 
Thanks Florian!