After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 726315 - clutter-stage-wayland: Enable clipped redraws
clutter-stage-wayland: Enable clipped redraws
Status: RESOLVED FIXED
Product: clutter
Classification: Platform
Component: wayland
unspecified
Other All
: Normal normal
: ---
Assigned To: clutter-maint
clutter-maint
Depends on:
Blocks:
 
 
Reported: 2014-03-14 10:00 UTC by drago01
Modified: 2014-03-14 16:57 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
clutter-stage-wayland: Enable clipped redraws (1.48 KB, patch)
2014-03-14 10:00 UTC, drago01 		accepted-commit_now Details | Review
clutter-stage-wayland: Enable clipped redraws (2.02 KB, patch)
2014-03-14 10:05 UTC, drago01 		none Details | Review
clutter-stage-wayland: Enable clipped redraws (1.48 KB, patch)
2014-03-14 11:31 UTC, drago01 		committed Details | Review

Description drago01 2014-03-14 10:00:36 UTC 
See patch.
Comment 1 drago01 2014-03-14 10:00:38 UTC 
Created attachment 271845 [details] [review]
clutter-stage-wayland: Enable clipped redraws

_clutter_stage_window_can_clip_redraws is used to check for clipped redraws
support but can_clip_redraws is not implemented by clutter-stage-wayland so
it always returns FALSE causing full screen redraws.

Fix that by implementing can_clip_redraws in clutter-stage-wayland.
Comment 2 drago01 2014-03-14 10:05:37 UTC 
Created attachment 271847 [details] [review]
clutter-stage-wayland: Enable clipped redraws

_clutter_stage_window_can_clip_redraws is used to check for clipped redraws
support but can_clip_redraws is not implemented by clutter-stage-wayland so
it always returns FALSE causing full screen redraws.

Fix that by implementing can_clip_redraws in clutter-stage-wayland.


Fix typo.
Comment 3 drago01 2014-03-14 11:31:11 UTC 
Created attachment 271872 [details] [review]
clutter-stage-wayland: Enable clipped redraws

_clutter_stage_window_can_clip_redraws is used to check for clipped redraws
support but can_clip_redraws is not implemented by clutter-stage-wayland so
it always returns FALSE causing full screen redraws.

Fix that by implementing can_clip_redraws in clutter-stage-wayland.
Comment 4 Emmanuele Bassi (:ebassi) 2014-03-14 16:52:50 UTC 
Review of attachment 271845 [details] [review]:

looks good.
Comment 5 Emmanuele Bassi (:ebassi) 2014-03-14 16:55:35 UTC 
Review of attachment 271872 [details] [review]:

again, looks good.
Comment 6 drago01 2014-03-14 16:57:25 UTC 
Attachment 271872 [details] pushed as f649d73 - clutter-stage-wayland: Enable clipped redraws