After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 726262 - screenShield: fix lifting when inserting smartcard
screenShield: fix lifting when inserting smartcard
Status: RESOLVED FIXED
Product: gnome-shell
Classification: Core
Component: lock-screen
unspecified
Other All
: Normal normal
: ---
Assigned To: gnome-shell-maint
gnome-shell-maint
Depends on:
Blocks:
 
 
Reported: 2014-03-13 17:39 UTC by Ray Strode [halfline]
Modified: 2014-03-13 18:01 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
screenShield: fix lifting when inserting smartcard (3.90 KB, patch)
2014-03-13 17:39 UTC, Ray Strode [halfline] 		committed Details | Review
util: fix "login card" smartcard detection on unlock screen (3.08 KB, patch)
2014-03-13 17:51 UTC, Ray Strode [halfline] 		committed Details | Review

Description Ray Strode [halfline] 2014-03-13 17:39:05 UTC 
If a user inserts the smartcard they logged in with into the system,
it's supposed to lift the shield and prompt for pin.  That doesn't
happen because the parameter list of the smartcard-inserted signal
handler is wrong.

This commit fixes that.
Comment 1 Ray Strode [halfline] 2014-03-13 17:39:07 UTC 
Created attachment 271771 [details] [review]
screenShield: fix lifting when inserting smartcard
Comment 2 Giovanni Campagna 2014-03-13 17:41:05 UTC 
Review of attachment 271771 [details] [review]:

LG
Comment 3 Ray Strode [halfline] 2014-03-13 17:51:13 UTC 
okay one more i'll hijack this bug for, since it's tangentially related.
Comment 4 Ray Strode [halfline] 2014-03-13 17:51:29 UTC 
Created attachment 271774 [details] [review]
util: fix "login card" smartcard detection on unlock screen

We only want to react to the card the user logged in with, at
the unlock screen.  We check "at the unlock screen" by checking
the "reauthenticating" state variable.  That variable is the
wrong one, though. It gets set too late, and in some cases, gets
set at the login screen, too.  We should be checking this._reauthOnly
instead.

This commit fixes that.
Comment 5 Giovanni Campagna 2014-03-13 17:54:03 UTC 
Review of attachment 271774 [details] [review]:

Ok
Comment 6 Ray Strode [halfline] 2014-03-13 18:01:19 UTC 
Attachment 271771 [details] pushed as 7d5ce1a - screenShield: fix lifting when inserting smartcard
Attachment 271774 [details] pushed as ff5550c - util: fix "login card" smartcard detection on unlock screen